Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove GridFeatureModeConstant #6077

Merged
merged 4 commits into from
Sep 27, 2022

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Sep 8, 2022

Based on #6003 (comment)

Changelog

Breaking change

The GridFeatureModeConstant constant no longer exsits.

- import { GridFeatureModeConstant } from '@mui/x-data-grid';

@DanailH DanailH added core Infrastructure work going on behind the scenes breaking change component: data grid This is the name of the generic UI component, not the React module! labels Sep 8, 2022
@DanailH DanailH self-assigned this Sep 8, 2022
@mui-bot
Copy link

mui-bot commented Sep 8, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 512.8 948.5 678 719.72 185.19
Sort 100k rows ms 589.4 1,112.6 589.4 874.12 186.871
Select 100k rows ms 191.1 271.2 250.2 233.72 34.241
Deselect 100k rows ms 115.6 234.6 214.8 197.9 42.042

Generated by 🚫 dangerJS against ad09894

@DanailH DanailH mentioned this pull request Sep 8, 2022
41 tasks
@DanailH DanailH changed the base branch from master to next September 12, 2022 09:32
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you update the description with the breaking change message for users depending on this export.

@cherniavskii
Copy link
Member

cherniavskii commented Sep 20, 2022

Nice! I was wondering about this enum #5214 (comment), good to see it's gone now 👍

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 26, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 27, 2022
@DanailH DanailH merged commit 85dadfa into mui:next Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants