Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Render SortGridMenuItems with sortingOrder props #7108

Closed
wants to merge 508 commits into from
Closed

[DataGrid] Render SortGridMenuItems with sortingOrder props #7108

wants to merge 508 commits into from

Conversation

hanbin9775
Copy link
Contributor

Fixes: #7103

SortGridMenuItems were being rendered regardless of the sortingOrder props.

alexfauquette and others added 30 commits October 25, 2022 09:11
@alexfauquette
[docs] Add feedback in next doc (mui#6591)
3d160f7
@alexfauquette
[pickers] Import fixes for mask editing (mui#6623)
e8ed7b0
@flaviendelangle
[core] Fix spreading on validation page (mui#6624)
499462b
@flaviendelangle
[docs] New page to migrate pickers from v5 to v6 (mui#6472)
de31ee7
@oliviertassinari
[core] Fix duplicate CodeQL build
26bc7c1 
For example in https://github.com/mui/mui-x/actions/runs/3318124358
it ran twice to do the same thing. I got confirmation from GitHub
that it's duplication in github/codeql-action#1319 (comment).
@LukasTy
[pickers] Rename remaining private components (mui#6550)
b2ff97f
@e-cloud @cherniavskii
[DataGrid] Allow to disable autofocusing the search field in the colu…
5357eb9 
…mns panel (mui#6444)

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
@banoth-ravinder
[docs] Fix typo in DataGrid demo page (mui#6632)
9abf686
@DanailH
[DataGrid] Rename GridColumnsState['all'] to `GridColumnsState['ord…
3cb20db 
…eredFields']` (mui#6562)
@cherniavskii
[DataGrid] Fix setRows method not persisting new rows data after `l…
44ed647 
…oading` prop change (mui#6493)
@alexfauquette
[docs] Remove broken welcome page (mui#6585)
aedef63
@alexfauquette
[DateTimePicker] Fix toolbar time order when theme.rtl=true (mui#6636)
e28780b
@cherniavskii
[docs] Disable translations (mui#6560)
7a7977f
@alexfauquette
[docs] Mark data grid column group as available (mui#6660)
f3e2d52
@renovate
Bump react-hook-form to ^7.38.0 (mui#6613)
6120da6 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump eslint to ^8.26.0 (mui#6612)
6322453 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump concurrently to ^7.5.0 (mui#6611)
75dcc1a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump @visx/xychart to ^2.16.0 (mui#6610)
733aeb8 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump util to ^0.12.5 (mui#6609)
bf52c95 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump dayjs to ^1.11.6 (mui#6607)
9807ad0 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump chance to ^1.1.9 (mui#6606)
480690d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump @docsearch/react to ^3.3.0 (mui#6603)
1a49a3c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump @types/luxon to ^3.0.2 (mui#6604)
cd24963 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump eslint-plugin-jsdoc to ^39.3.25 (mui#6608)
99030b6 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump lerna to ^6.0.1 (mui#6533)
1a5702c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump @octokit/rest to ^19.0.5 (mui#6532)
59d2211 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump mocha to ^10.1.0 (mui#6530)
ca24313 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@oliviertassinari
[docs] Fix double space
6be2f76
@oliviertassinari
[core] Change reproduction position (mui#6621)
9e5d973
@oliviertassinari
[core] Remove legacy migration function (mui#6669)
0775923
joserodolfofreitas and others added 20 commits December 1, 2022 13:07
@joserodolfofreitas
[Data Grid] Remove the statement of support to RTL (mui#6521)
edb8aac
@flaviendelangle
[core] Unify testing of the value related props (mui#6964)
214063e
@alexfauquette
v6.0.0-alpha.10 (mui#7060)
09ca123
@oliviertassinari
[docs] Fix API page ad space regression (mui#7051)
4f70faf
@renovate
Bump typescript-eslint to ^5.45.0 (mui#7022)
3029bbe 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump github/codeql-action action to v2.1.35 (mui#7013)
1102ec9 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Bump prettier to ^2.8.0 (mui#7021)
b7b6b20 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@LukasTy
[DateRangePicker] Add dragging support to edit range (mui#6763)
6cc2f70
@cherniavskii
[test] Fix karma-mocha assertion error messages (mui#7054)
6e0feb3
@cherniavskii
[DataGrid] Remove Header slot (mui#6999)
626106b 
Closes mui#6977
@MBilalShafi @m4theushw
[DataGrid] Rename filterPanelOperators -> filterPanelOperator (mu…
d8b76d3 
…i#7062)

Signed-off-by: Bilal Shafi <bilalshafidev@gmail.com>
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
@flaviendelangle
[pickers] Fix toolbar on the new range pickers (mui#6989)
f53506d
@flaviendelangle
[pickers] Fix lost props on Date Range Pickers (mui#7092)
2a774ea
@flaviendelangle
[core] Remove unused code (mui#7094)
9d6e9c5
@MBilalShafi @cherniavskii
[DataGrid] Add GridCell change in migration guide (mui#7087)
1ff32ae 
Signed-off-by: Bilal Shafi <bilalshafidev@gmail.com>
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
@oliviertassinari
[core] Sync ApiPage.js with monorepo (mui#7073)
ea48b38
@MBilalShafi @cherniavskii
[DataGrid] Fixes rows not rendering properly after height change (mui…
3123d3a 
…#6892)

Signed-off-by: Bilal Shafi <bilalshafidev@gmail.com>
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
@flaviendelangle
[pickers] Improve performances of DayCalendar (mui#7066)
874ad18
@flaviendelangle
[pickers] Remove the callback version of the action prop in the `ac…
8908683 
…tionBar` component slot (mui#7038)
@hanbin9775
[DataGrid] Render SortGridMenuItems with sortingOrder props
4afd4ae
@hanbin9775 hanbin9775 closed this Dec 6, 2022
@mui-bot
Copy link

mui-bot commented Dec 6, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-7108--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 633.3 905.5 748.1 751.74 100.074
Sort 100k rows ms 575.8 1,011.9 575.8 862.24 167.578
Select 100k rows ms 208 279.1 216.7 226.72 26.395
Deselect 100k rows ms 140.5 288.8 170.3 203.74 61.051

Generated by 🚫 dangerJS against 3861bc1

@hanbin9775 hanbin9775 reopened this Dec 6, 2022
@MBilalShafi
Copy link
Member

@hanbin9775 Can you set the target branch as master? For next it'll be fixed along with #6619

@hanbin9775 hanbin9775 changed the base branch from next to master December 6, 2022 18:01
@hanbin9775
Copy link
Contributor Author

Oops, I probably should work on from master branch.
I will close this pr and create new one from master branch.

@hanbin9775 hanbin9775 closed this Dec 6, 2022
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Remove Unsort from the column menu if sortingOrder is ['asc', 'desc']