Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Upgrade monorepo #8169

Merged
merged 1 commit into from
Mar 7, 2023
Merged

[core] Upgrade monorepo #8169

merged 1 commit into from
Mar 7, 2023

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes labels Mar 7, 2023
@mui-bot
Copy link

mui-bot commented Mar 7, 2023

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 599.7 1,126.9 599.7 825.32 213.623
Sort 100k rows ms 692.2 1,292.1 692.2 956.42 227.678
Select 100k rows ms 211.6 352.5 259.3 277.86 57.691
Deselect 100k rows ms 166.4 304.8 232.6 235.78 51.476

Generated by 🚫 dangerJS against 1f0a4b5

@cherniavskii cherniavskii marked this pull request as ready for review March 7, 2023 18:27
@cherniavskii cherniavskii merged commit e5de4cc into mui:docs-v5 Mar 7, 2023
oliviertassinari pushed a commit that referenced this pull request Mar 18, 2023
@cherniavskii @oliviertassinari
[core] Upgrade monorepo (#8169)
e3e18b7
@oliviertassinari
Copy link
Member

The target branch looks wrong:

Screenshot 2023-03-19 at 00 44 11

I have cherry-picked it to the v5.x branch: https://github.com/mui/mui-x/commits/v5.x

@cherniavskii cherniavskii deleted the upgrade-monorepo-v5 branch March 20, 2023 17:44
@cherniavskii
Copy link
Member Author

@oliviertassinari right, it should have been merged into v5.x and then pushed to docs-v5 👍
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation v5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cherniavskii @mui-bot @oliviertassinari @m4theushw