[core] Allow to select a section by type in field tests #9009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
core
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9009--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
flaviendelangle
force-pushed
the
field-selected-sections-test
branch
from
3349c78
to
5e2d75c
Compare
flaviendelangle
force-pushed
the
field-selected-sections-test
branch
2 times, most recently
from
3fb6d6b
to
92be206
Compare
flaviendelangle
force-pushed
the
field-selected-sections-test
branch
from
92be206
to
59b1daa
Compare
LukasTy
approved these changes
May 19, 2023
packages/x-date-pickers/src/DateField/tests/editing.DateField.test.tsx
Outdated
Show resolved
Hide resolved
flaviendelangle
force-pushed
the
field-selected-sections-test
branch
from
42aa2a8
to
284e930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have
fieldRef, we are able to provide a better DX in our tests.We created several ways of selecting a section and I'm trying to unify all of that into a single, easy to understand, API.