Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Improve tree data performance #9682

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[DataGridPro] Improve tree data performance #9682

merged 1 commit into from
Jul 18, 2023

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Jul 14, 2023 •
edited
Loading

@cherniavskii cherniavskii added performance component: data grid This is the name of the generic UI component, not the React module! feature: Tree data Related to the data grid Tree data feature labels Jul 14, 2023
@mui-bot
Copy link

mui-bot commented Jul 14, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9682--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 318.2 520.4 425.5 409.32 80.213
Sort 100k rows ms 464.1 1,000.7 588.5 742 196.199
Select 100k rows ms 186.8 236.3 193.3 201.32 17.991
Deselect 100k rows ms 130.9 225.9 150.5 170.26 38.209

Generated by 🚫 dangerJS against 6e9d13b

@cherniavskii cherniavskii requested a review from romgrk July 14, 2023 18:34
@cherniavskii cherniavskii added regression A bug, but worse plan: Premium Impact at least one Premium user labels Jul 14, 2023
@cherniavskii cherniavskii mentioned this pull request Jul 14, 2023
Closed
2 tasks
romgrk
romgrk approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@romgrk romgrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this looks good, this seems like a super easy win.

@cherniavskii cherniavskii marked this pull request as ready for review July 18, 2023 14:14
@cherniavskii cherniavskii merged commit 452b48c into mui:master Jul 18, 2023
@cherniavskii cherniavskii deleted the tree-data-performance branch July 18, 2023 14:15
MBilalShafi pushed a commit that referenced this pull request Aug 2, 2023
@cherniavskii @MBilalShafi
[DataGridPro] Improve tree data performance (#9682)
dc89cf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Tree data Related to the data grid Tree data feature performance plan: Premium Impact at least one Premium user regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Performance degradation with v6.x and tree data
3 participants
@cherniavskii @mui-bot @romgrk