Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] Export globalCss from index #148

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

siriwatknp
Copy link
Member

closes #142 (globalCss is missing from the index)

  • added typecheck
  • added cli.js from the core to run tests in watch mode with selectable pattern.

@siriwatknp siriwatknp added the bug 🐛 Something doesn't work label Jun 19, 2024
@@ -28,7 +28,7 @@
"test": "cd ../../ && cross-env NODE_ENV=test BABEL_ENV=coverage nyc --reporter=text mocha 'packages/pigment-css-react/**/*.test.{js,ts,tsx}'",
"test:update": "cd ../../ && cross-env NODE_ENV=test UPDATE_FIXTURES=true mocha 'packages/pigment-css-react/**/*.test.{js,ts,tsx}'",
"test:ci": "cd ../../ && cross-env NODE_ENV=test BABEL_ENV=coverage nyc --reporter=lcov --report-dir=./coverage/pigment-css-react mocha 'packages/pigment-css-react/**/*.test.{js,ts,tsx}'",
"typecheck": "tsc --noEmit -p ."
"typescript": "tsc --noEmit -p ."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the core repo.

@@ -0,0 +1,125 @@
const childProcess = require('child_process');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste from the core repo.

@siriwatknp siriwatknp merged commit 7678829 into master Jun 19, 2024
17 of 18 checks passed
@siriwatknp siriwatknp deleted the fix/global-css-export branch June 19, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

globalCss is missing in build/index after publishing
2 participants