Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove paths associated with the @mui packages #15

Merged
merged 2 commits into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions apps/pigment-css-next-app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ Open [http://localhost:3000](http://localhost:3000) to see the app running live.

You can start editing the page by modifying `app/page.tsx`. The page auto-updates as you edit the file.

If you encounter an error that says "package `@pigment-css/react` not found," add it as a peer dependency in the `package.json` for `@mui/material`, then run `pnpm build` and `pnpm install` again. Make sure to not push this change to git.

### Note

If you're testing changes in Pigment CSS-related packages while also running this demo app, run the watch command in a separate terminal to watch and build Pigment CSS package files as they change:
Expand Down
2 changes: 0 additions & 2 deletions apps/pigment-css-vite-app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,3 @@ After building, you can run the project by changing into the directory and then:
3. Build the code using `pnpm build`

Optionally, before running the dev server, you can run `pnpm vite optimize --force` if it logs an error while running `pnpm vite`.

If you encounter an error that says "package `@pigment-css/react` not found," add it as a peer dependency in the `package.json` for `@mui/material`, then run `pnpm build` and `pnpm install` again. Make sure to not push this change to git.
1 change: 1 addition & 0 deletions packages/pigment-css-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"@emotion/serialize": "^1.1.4",
"@emotion/styled": "^11.11.5",
"@mui/system": "^6.0.0-alpha.1",
"@mui/utils": "^6.0.0-alpha.1",
"@wyw-in-js/processor-utils": "^0.5.0",
"@wyw-in-js/shared": "^0.5.0",
"@wyw-in-js/transform": "^0.5.0",
Expand Down
6 changes: 0 additions & 6 deletions packages/pigment-css-react/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@
"composite": true,
"noEmit": false,
"resolveJsonModule": true,
"paths": {
"@mui/system": ["./packages/mui-system/src"],
"@mui/system/*": ["./packages/mui-system/src/*"],
"@mui/utils": ["./packages/mui-utils/src"],
mnajdova marked this conversation as resolved.
Show resolved Hide resolved
"@mui/utils/*": ["./packages/mui-utils/src/*"]
},
"types": ["node", "mocha"]
},
"include": ["src/**/*.tsx", "src/**/*.js"],
Expand Down
4 changes: 0 additions & 4 deletions packages/pigment-css-unplugin/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
"target": "ES2022",
"paths": {
"@babel/core": ["./node_modules/@babel/core"],
"@mui/system": ["./packages/mui-system/src"],
"@mui/system/*": ["./packages/mui-system/src/*"],
"@mui/utils": ["./packages/mui-utils/src"],
"@mui/utils/*": ["./packages/mui-utils/src/*"],
"@pigment-css/react": ["./packages/pigment-css-react/src"],
"@pigment-css/react/*": ["./packages/pigment-css-react/src/*"]
},
Expand Down
4 changes: 0 additions & 4 deletions packages/pigment-css-vite-plugin/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
"target": "ES2022",
"paths": {
"@babel/core": ["./node_modules/@babel/core"],
"@mui/system": ["./packages/mui-system/src"],
"@mui/system/*": ["./packages/mui-system/src/*"],
"@mui/utils": ["./packages/mui-utils/src"],
"@mui/utils/*": ["./packages/mui-utils/src/*"],
"@pigment-css/react": ["./packages/pigment-css-react/src"],
"@pigment-css/react/*": ["./packages/pigment-css-react/src/*"]
}
Expand Down
4 changes: 4 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.