Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue if the subsystem is already gone #1

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Conversation

woswos
Copy link
Member

@woswos woswos commented Feb 10, 2023

In v1 cgroups, multiple directories point to the same directory. When all of these controllers are enabled at the same time, this library tries to delete the directories it already deleted (because of the symlinks). So, I fixed it.

root@root:/sys/fs/cgroup# ls -l
total 0
drwxr-xr-x 3 root root  0 Feb 10 10:49 blkio
lrwxrwxrwx 1 root root 11 Feb 10 10:49 cpu -> cpu,cpuacct
lrwxrwxrwx 1 root root 11 Feb 10 10:49 cpuacct -> cpu,cpuacct
drwxr-xr-x 3 root root  0 Feb 10 10:49 cpu,cpuacct
drwxr-xr-x 3 root root  0 Feb 10 10:49 cpuset
drwxr-xr-x 3 root root  0 Feb 10 10:49 devices
drwxr-xr-x 3 root root  0 Feb 10 10:49 freezer
drwxr-xr-x 3 root root  0 Feb 10 10:49 hugetlb
drwxr-xr-x 3 root root  0 Feb 10 10:49 memory
dr-xr-xr-x 2 root root  0 Feb 10 10:24 misc
lrwxrwxrwx 1 root root 16 Feb 10 10:49 net_cls -> net_cls,net_prio
drwxr-xr-x 3 root root  0 Feb 10 10:49 net_cls,net_prio
lrwxrwxrwx 1 root root 16 Feb 10 10:49 net_prio -> net_cls,net_prio
drwxr-xr-x 3 root root  0 Feb 10 10:49 perf_event
drwxr-xr-x 3 root root  0 Feb 10 10:49 pids
drwxr-xr-x 3 root root  0 Feb 10 10:49 rdma
drwxr-xr-x 2 root root  0 Feb 10 10:49 systemd

@woswos woswos changed the title Continur if the subsystem is already gone Continue if the subsystem is already gone Feb 10, 2023
@woswos woswos requested a review from ziyan February 10, 2023 02:03
@ziyan ziyan merged commit 540dd84 into mujin Feb 10, 2023
@ziyan ziyan deleted the fixV1Delete20230210 branch February 10, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants