This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok what we got so far:
We need to differ two deserialization strategies:
The manuel one:
here we need the getNullValue implementation of StdDeserializer
and the one used in Jackson Deserialization with JsonNode:
here we need the if (node.isNull()) check
I left both in there so we can't get something wrong then (one does not work without the other).
The other thing really was a bug when calling the constructor with null value, as constructor thought we put in a Integer or Boolean or String...
Which leads us to the next point: ambiguity!
I removed all constructors and only left one private empty constructor, indicating that the object was not correctly initialized (all null, also enum null)
And i added one constructor with Object as argument, checking the given value against all possibilities to build the correct Union type. This also handles the null value correctly and someone can use following code to create a StringNilUnion:
One does not need to care to call the empty constructor for null values anymore. If the type does not fit, an IllegalArgumentException is thrown.
Some other changes: