Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to debian stretch #40

Closed
wants to merge 1 commit into from
Closed

Conversation

andrusha
Copy link

@andrusha andrusha commented Oct 28, 2019

  • Jessie is EOL was on 2018-06-17
  • Jessie packages are outdated (ie, no jdk-11)
  • Emdebian was dead since 2013
  • osxcross is upgraded to the latest commit hash

The DarwinSDK needs to be updated (who owns that Dropbox link?), otherwise build fails:

In file included from code-sign-blobs/blob.cpp:29:
In file included from code-sign-blobs/blob.h:45:
In file included from code-sign-blobs/endian.h:34:
code-sign-blobs/memutils.h:96:42: error: unknown type name 'ptrdiff_t'; did you mean 'std::ptrdiff_t'?
inline const T *increment(const void *p, ptrdiff_t offset)
                                         ^~~~~~~~~
                                         std::ptrdiff_t
/usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/x86_64-linux-gnu/c++/6.3.0/bits/c++config.h:202:28: note: 'std::ptrdiff_t' declared here
  typedef __PTRDIFF_TYPE__      ptrdiff_t;
                                ^

* Jessie is EOL was on 2018-06-17
* Jessie packages are outdated (ie, no jdk-11)
* Emdebian was dead since 2013
* osxcross is upgraded to the latest commit hash

The DarwinSDK needs to be updated, otherwise build fails:
```
In file included from code-sign-blobs/blob.cpp:29:
In file included from code-sign-blobs/blob.h:45:
In file included from code-sign-blobs/endian.h:34:
code-sign-blobs/memutils.h:96:42: error: unknown type name 'ptrdiff_t'; did you mean 'std::ptrdiff_t'?
inline const T *increment(const void *p, ptrdiff_t offset)
                                         ^~~~~~~~~
                                         std::ptrdiff_t
/usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/x86_64-linux-gnu/c++/6.3.0/bits/c++config.h:202:28: note: 'std::ptrdiff_t' declared here
  typedef __PTRDIFF_TYPE__      ptrdiff_t;
                                ^
```
@yuzawa-san
Copy link

I was playing around with this and found that adding libxml2-dev, libssl-dev, libz-dev to the initial apt-get allowed the build to proceed past the point of failure in the travis ci build.

However, my docker build fails later in this shell section:

RUN for triple in $(echo ${LINUX_TRIPLES} | tr "," " "); do \

It seems to be using sh instead of bash. Even when I force it to use bash, it does not work. This may be an unrelated bug beyond the scope of your original changes. I'm no docker or bash expert, so I don't really know of a fix. My gut tells me that the glob operations may be returning unexpected output.

What are your thoughts on upgrading to buster instead of stretch?

@inolen
Copy link

inolen commented Jan 2, 2020

Hi @andrusha @yuzawa-san ,

I took your work and finished getting it working last night with the current SDK. Tested with the x86_64-apple-darwin, x86_64-w64-mingw32 and default x86_64-linux-gnu triple.

I've attached a patch, do you want to just update this PR with it?

WORKING.txt

@yuzawa-san
Copy link

@inolen your patch looks good to me

What do you think about upgrading to buster? I suppose I would yield to the maintainers, but buster is stable per debian's website. I tried your patch with buster and it worked as well.

@inolen
Copy link

inolen commented Jan 3, 2020

@yuzawa-san I'd prefer to leave it at the older of the two libc's given the choice.

@lafin lafin closed this Jan 17, 2020
@lafin
Copy link
Contributor

lafin commented Jan 17, 2020

already solved #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants