Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free Arbitrary implementation from codetable #141

Closed
vmx opened this issue Aug 24, 2023 · 1 comment · Fixed by #144
Closed

Free Arbitrary implementation from codetable #141

vmx opened this issue Aug 24, 2023 · 1 comment · Fixed by #144
Labels
difficulty:easy help wanted

Comments

@vmx
Copy link
Member

vmx commented Aug 24, 2023

Once #140 is merged, only the Arbitrary implementations require the multihash-codetable. That's quite a big dependency, hence it would make sense to hard-code the codec and use the sha2 crate directly.

This way multihash-codetable can be moved into the dev-dependency section.
@vmx vmx mentioned this issue Sep 11, 2023
Merged
@thomaseizinger thomaseizinger mentioned this issue Sep 11, 2023
Merged
@vmx vmx closed this as completed in #144 Sep 11, 2023
vmx pushed a commit that referenced this issue Sep 11, 2023
@thomaseizinger
chore: make multihash-codetable a dev-dependency (#144)
7427a7b 
Fixes #141.
@Lawere
Copy link

Lawere commented Sep 11, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make multihash-codetable a dev-dependency thomaseizinger/rust-cid
2 participants
@vmx @Lawere