Update multihash dependency to fix panic on some types of bad input #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattheworris
added a commit
to frequency-chain/frequency
that referenced
this pull request
Apr 17, 2023
# Goal The goal of this PR is to add a unit test in the messages pallet to detect a panic on some types of bad cids. `multihash` v0.18.1 fixes an issue with calling `unwrap()` on certain types of errors in a `no-std` environment. `multihash` is included by the `cid` crate used for IPFS messages. [`Cargo.lock` was updated by another PR before this was merged, so v0.18.1 is already there] Closes #1233 Further updates in progress #1417 multiformats/rust-cid#135
|
I totally missed that PR. A Current master branch is now at multihash v0.19, which contains that fix. |
Do you recommend using the master branch in the cargo dependencies or will there be a new release to crates.io? |
But cid v0.10.1 should resolve to multihash v0.18.1. |
|
You are correct, we are now getting v0.18.1. Thanks, somewhere I missed the
dependency update.
…On Mon, Sep 11, 2023 at 2:21 PM Volker Mische ***@***.***> wrote:
We're using cid = 0.10.1 as a dependency, so cargo update is not
resolving to multihash v0.19.
But cid v0.10.1 should resolve to multihash v0.18.1.
—
Reply to this email directly, view it on GitHub
<#135 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALGDXHGTWJXNSCNMNSV4XLXZ5XDDANCNFSM6AAAAAAXBLNEVQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
rustadot
pushed a commit
to rustadot/recurrency
that referenced
this pull request
Sep 5, 2024
# Goal The goal of this PR is to add a unit test in the messages pallet to detect a panic on some types of bad cids. `multihash` v0.18.1 fixes an issue with calling `unwrap()` on certain types of errors in a `no-std` environment. `multihash` is included by the `cid` crate used for IPFS messages. [`Cargo.lock` was updated by another PR before this was merged, so v0.18.1 is already there] Closes #1233 Further updates in progress #1417 multiformats/rust-cid#135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multihash:0.18.0can panic on some types of bad input.Require v0.18.1 in dependencies to avoid panics.
See the following pull request for more information:
multiformats/rust-multihash#293