Fix #1357: discord crashes from a4f447ae8047b6d2d65077f093adff69 #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into discordfix
…into discordfix
qaisjp
reviewed
Apr 7, 2020
qaisjp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1357
and
#1349 (comment)
I still need feedback on this @Dutchman101 but I'm guessing this is totally bug-free now because I spent hours evaluating this crashy part and I actually forgot them because my PR was large and merged with a huge delay, this mess up was caused by not having the free time to actually test the code and just fixed it as quick as I could, now I've spent a lot of time reading everything. Hope this addresses all the crashes now.