Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CConsole.cpp #21

Merged
merged 1 commit into from
Dec 23, 2015
Merged

Update CConsole.cpp #21

merged 1 commit into from
Dec 23, 2015

Conversation

Necktrox
Copy link
Contributor

Improve the log message in case a player has not enough permission to execute a command

Improve the log message in case a player has not enough permission to execute a command
@qaisjp
Copy link
Contributor

qaisjp commented Dec 23, 2015

Thanks for the PR, but I'm not too sure if this change is necessary.

At first glance it seems that DENIED: is more informative and would match any other instances where denied accesses are being logged. On the other hand, (after a quick GitHub search) I can't find any other instances of DENIED:, so this change wouldn't really make a difference.

I'll merge it anyway. Sorry to be pedantic, but in the future please write more informative commit titles. As a rule of thumb, titles should be a summary of the commit description. The description was fine, however :)

qaisjp added a commit that referenced this pull request Dec 23, 2015
Improve ACL "access denied" log message
@qaisjp qaisjp merged commit f98a3cb into multitheftauto:master Dec 23, 2015
@Necktrox Necktrox deleted the patch-1 branch December 23, 2015 15:58
@Necktrox
Copy link
Contributor Author

You're right. I should've edited the title to match the pull request intention. The title "DENIED" was confusing to read in the server log and it wasn't really telling me the origin of the problem. And creating a quick PR was a good way to fix that.

@qaisjp
Copy link
Contributor

qaisjp commented Dec 23, 2015

That makes sense. Thanks again for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants