Fix maxTrieLevelInMemory invalid value #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
previously approved these changes
May 18, 2020
data/trie/patriciaMerkleTrie.go
Outdated
| @@ -514,7 +517,9 @@ func (tr *patriciaMerkleTrie) GetSerializedNodes(rootHash []byte, maxBuffToSend | |||
|
|
|||
| // GetAllLeaves iterates the trie and returns a map that contains all leafNodes information | |||
| func (tr *patriciaMerkleTrie) GetAllLeaves() (map[string][]byte, error) { | |||
| //TODO: save those leafs into a levelDB struct (cache and storage) and at processing time to get from that structure. | |||
| tr.mutOperation.Lock() | |||
…0-fix-maxTrieLevelInMemory-on-sync
SebastianMarian
approved these changes
May 19, 2020
sasurobert
approved these changes
May 19, 2020
LucianMincu
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing mutex to GetAllLeaves() from trie.
Initialize maxTrieLevelInMemory in all the places in which maxTrieLevelInMemory=0
Return error if maxTrieLevelInMemory is initialized with 0.