Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disabled nat service #1762

Merged
merged 7 commits into from
May 21, 2020
Merged

disabled nat service #1762

merged 7 commits into from
May 21, 2020

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented May 19, 2020 •
edited
Loading

  • disabled NAT service option from the libp2p host. Not required to run our nodes.

// EnableNATService configures libp2p to provide a service to peers for determining
// their reachability status. When enabled, the host will attempt to dial back
// to peers, and then tell them if it was successful in making such connections.

The reason behind this is that it is useless that a node will find out its reachability status through this method as it will still be unreachable from outside (NAT UPnP did not succeed or the node is behind a firewall). We will provide a service for this as to allow validators to correctly configure their firewall and NAT settings.

@iulianpascalau iulianpascalau self-assigned this May 19, 2020
@miiu96 miiu96 closed this May 21, 2020
@miiu96 miiu96 deleted the disable-autonat-service branch May 21, 2020 06:08
@iulianpascalau iulianpascalau restored the disable-autonat-service branch May 21, 2020 06:14
LucianMincu
LucianMincu approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@LucianMincu LucianMincu merged commit 4a53285 into development May 21, 2020
@LucianMincu LucianMincu deleted the disable-autonat-service branch May 21, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@SebastianMarian SebastianMarian SebastianMarian approved these changes

Assignees

@iulianpascalau iulianpascalau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iulianpascalau @sasurobert @LucianMincu @SebastianMarian @miiu96