Feat fix peers rating handler

[sstanculeanu]

Reasoning behind the pull request

• missing call to DecreaseRating + found a better approach

Proposed changes

• added multiple fixes to peers rating handler + integration tests

Testing procedure

• integration tests + system test scenario:
  • start a testnet from test_peersRatingHandler branch which has some extra logs(printed each 10 seconds)
  • start a node connected to this testnet using test_peersRatingHandler_malicious branch(this one should not respond to requests after nonce 1000, ~epoch 5-6). let's call it malicious node.
  • get the pid of this malicious node
  • check the logs of the nodes from testnet for testing- Ratings cachers. Following this line should be displayed full list of peers and their ratings, we should see ratings trending to 100 before nonce 1000(including for the malicious node)
  • check the new route for ratings: /node/connected-peers-ratings which should provide same results with the log after testing- Connected peers ratings:
  • after nonce 1000, we should start seeing the rating of malicious node decreasing, perhaps going to the bad rated list.

Note: during testing, you will see log errors testing- forced to not respond to requests anymore. They are the forced errors on malicious node. This confirms that the node does what is should do.

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

• was the PR targeted to the correct branch?
• if this is a larger feature that probably needs more than one PR, is there a feat branch created?
• if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (rc/v1.6.0@e272723). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head a44b682 differs from pull request most recent head 79146d3. Consider uploading reports for the commit 79146d3 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@             Coverage Diff              @@
##             rc/v1.6.0    #4800   +/-   ##
============================================
  Coverage             ?   70.87%           
============================================
  Files                ?      675           
  Lines                ?    87654           
  Branches             ?        0           
============================================
  Hits                 ?    62129           
  Misses               ?    20854           
  Partials             ?     4671           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[gabi-vuls]

System test passed
@@ Log scanner @@

fix-peers-rating-handler

================================================================================

• Known Warnings 0
• New Warnings 0
• Known Errors 0
• New Errors 1
• Panics 0
  ================================================================================
• block hash does not match 11279
• wrong nonce in block 4035
• miniblocks does not match 0
• num miniblocks does not match 0
• miniblock hash does not match 0
• block bodies does not match 0
• receipts hash missmatch 0
  ================================================================================
• No jailed nodes on the thestnet
  ================================================================================