Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the p2p configs #5947

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Fixed the p2p configs #5947

merged 4 commits into from
Feb 13, 2024

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • fixed the p2p configs

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (452bf4b) 80.17% compared to head (bcfe253) 80.21%.

Additional details and impacted files
@@                Coverage Diff                @@
##           rc/v1.6.next1    #5947      +/-   ##
=================================================
+ Coverage          80.17%   80.21%   +0.03%     
=================================================
  Files                709      709              
  Lines              94172    94172              
=================================================
+ Hits               75506    75542      +36     
+ Misses             13317    13282      -35     
+ Partials            5349     5348       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sstanculeanu sstanculeanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue on fullArchiveP2P.toml and seed node p2p.toml

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.6.15-dev-config-eb2e06c06d -> fix-p2p-configs-143e5d619f

--- Specific errors ---

block hash does not match 222
wrong nonce in block 205
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 217
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@gabi-vuls gabi-vuls merged commit 34e2f28 into rc/v1.6.next1 Feb 13, 2024
8 checks passed
@gabi-vuls gabi-vuls deleted the fix-p2p-configs branch February 13, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants