Bug-fixes SetState chain simulator
#5993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstanculeanu
approved these changes
Feb 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.0 #5993 +/- ##
=============================================
- Coverage 80.25% 80.23% -0.02%
=============================================
Files 734 734
Lines 96383 96398 +15
=============================================
- Hits 77350 77343 -7
- Misses 13677 13699 +22
Partials 5356 5356 ☔ View full report in Codecov by Sentry. |
| @@ -3,7 +3,7 @@ package dtos | |||
| // AddressState will hold the address state | |||
| type AddressState struct { | |||
| Address string `json:"address"` | |||
| Nonce uint64 `json:"nonce,omitempty"` | |||
| Nonce *uint64 `json:"nonce,omitempty"` | |||
iulianpascalau
approved these changes
Feb 26, 2024
gabi-vuls
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
SetStateendpoint: instead of setting the provided balance the provided value was added to the balancePre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?