Update cookbook for SDK-JS #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
approved these changes
Apr 7, 2023
bogdan-rosianu
previously approved these changes
Apr 7, 2023
| ``` | ||
|
|
||
| <!-- END_INCLUDE_FILE --> | ||
|
|
||
| <!-- BEGIN_INCLUDE_FILE { "url": "https://raw.githubusercontent.com/multiversx/mx-sdk-js-examples/next/cookbook/generated/contracts_01_deployments.md" } --> |
There was a problem hiding this comment.
might reference a commit hash instead of the branch name? otherwise, make sure the next branch isn't removed in that repo
There was a problem hiding this comment.
Added commit hash.
schimih
reviewed
Apr 7, 2023
|
|
||
| A `TokenPayment` object for **EGLD transfers** (value movements): | ||
| A `TokenTransfer` object for **EGLD transfers** (value movements): |
| ``` | ||
|
|
||
| Note that the transaction needs to be signed before broadcasting it. Signing can be achieved using a signing provider. | ||
| Note that the transaction **must to be signed before being broadcasted**. Signing can be achieved using a signing provider. |
There was a problem hiding this comment.
must be signed before being broadcasted
|
|
||
| [comment]: # (mx-context-auto) | ||
|
|
||
| ## Token transfers | ||
|
|
||
| First, let's create a `TransferTransactionsFactory`. |
bogdan-rosianu
approved these changes
Apr 7, 2023
schimih
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request (what is new / what has changed)
Update SDK-JS cookbook for v12. Based on: multiversx/mx-sdk-js-examples#17.
Did you test the changes locally ?
Which category (categories) does this pull request belong to?