Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate impersonate callback function #30

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Validate impersonate callback function #30

merged 2 commits into from
Feb 7, 2024

Conversation

tanghel
Copy link
Contributor

@tanghel tanghel commented Feb 7, 2024

No description provided.

bogdan-rosianu
bogdan-rosianu reviewed Feb 7, 2024
View reviewed changes
README.md Outdated
impersonateUrl: string = 'https://extras-api.multiversx.com/impersonate/allowed';
validateImpersonateUrl: string = 'https://extras-api.multiversx.com/impersonate/allowed';

// An optioinal function that returns a boolean if the impersonation is accepted
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/entities/native.auth.server.config.ts Outdated
validateImpersonateUrl?: string;

/** An optioinal function that returns a boolean if the impersonation is accepted
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tanghel tanghel merged commit e875a4d into main Feb 7, 2024
1 check passed
@tanghel tanghel deleted the validate-impersonate-callback branch February 7, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfaur09 cfaur09 cfaur09 approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanghel @bogdan-rosianu @cfaur09