-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LineChart should not anchor the Y axis at zero #92
Comments
This is now fixed in the devel branch and will be in the next release. |
This worked great @mum4k thanks! |
@mum4k perhaps make it an option that can be passed to the line chart? Some people may still want it anchored at 0... especially ones already using it for that purpose. |
Thanks for the screenshot @activeshadow, glad to see this working. That is a valid point, we can add an option to control this behaviour. I wonder which of the two should be the default. Looking at how linecharts in spreadsheets behave - they anchor at zero by default. Would you be ok with that being the default behaviour and an option to remove the zero-anchor? That would make this change backward compatible. Let me know what you think. |
@mum4k having it be an option and making the default value be anchored at zero so the change is backwards compatible sounds great! Thanks! |
PR #96 is now merged into the devel branch. It adds a new linechart.YAxisAdaptive() option. Please give it a try and let me know if something doesn't work as expected. Thanks again for pointing out that this was going to introduce a backward-incompatible change. |
This loses precision when there are only higher positive values.
The min on the Y axis should be equal to the lowest provided value.
The text was updated successfully, but these errors were encountered: