[1/5] Defining options for the text widget. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each set of options applies to a range of characters equal to the length
of the text added.
E.g. on write calls like:
Write("text", opts1)
Write("long text", opts2)
The two passed options will be stored as:
opts1 for byte range low:0, high:4
opts2 for byte range low:4, high:13
The text itself will be stored in a bytes.Buffer.
The line scanner identifies and counts lines in the input text and performs wrapping if required.
And adding a demo.
Pull Request Test Coverage Report for Build 67
💛 - Coveralls |
chipmunkie
reviewed
May 20, 2018
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package text |
There was a problem hiding this comment.
Please provide a documentation for the package. Maybe it makes sense to move the comment related to the file on line 22 here.
There was a problem hiding this comment.
Sorry, this is related to how I split this into multiple pull requests. The documentation is in a later pull request, in the main file for this package.
chipmunkie
approved these changes
May 20, 2018
- renaming it to cvsWidth. - adding a comment explaining that it is the width of the canvas.
[5/5] Implementing the text widget.
[4/5] Adding an object that tracks the scrolling state.
[3/5] Adding line scanner.
[2/5] Defining options for text written to the widget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on #4