[4/5] Adding an object that tracks the scrolling state. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 61
💛 - Coveralls |
Pull Request Test Coverage Report for Build 24
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 24
💛 - Coveralls |
chipmunkie
approved these changes
May 26, 2018
| // scrollPage stores user requests to scroll up (negative) or down | ||
| // (positive) by a page of content. E.g. -1 means up by one page and 2 | ||
| // means down by two pages. | ||
| scrollPage int |
There was a problem hiding this comment.
What is not clear to me is how the scroll and scrollPage are maintained. If you scroll 2 lines up then scroll = -2. But if you scroll 2 pages and 1 line up does scroll = -1 and scrollPage = -2?
There was a problem hiding this comment.
I have expanded the comment for the object itself which now hopefully covers this.
widgets/text/scroll.go
Outdated
| return rollingPaused | ||
| } | ||
|
|
||
| // lastLineVisible returns true if the last line is visible given drawing that |
There was a problem hiding this comment.
Could we re-write this comment to clarify what the last line means. Is it the last line in the buffer?
There was a problem hiding this comment.
Comment rewritten. Please let me know if this doesn't help.
[5/5] Implementing the text widget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on #4