[3/5] Adding line scanner. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line scanner identifies and counts lines in the input text and performs wrapping if required.
And adding a demo.
Pull Request Test Coverage Report for Build 63
💛 - Coveralls |
chipmunkie
approved these changes
May 21, 2018
widgets/text/line_scanner_test.go
Outdated
| desc string | ||
| r rune | ||
| point image.Point | ||
| width int |
There was a problem hiding this comment.
Please add some clarification which field refers to the canvas. It's a bit confusing.
There was a problem hiding this comment.
Done. Added a comment and renamed width to cvsWidth.
- renaming it to cvsWidth. - adding a comment explaining that it is the width of the canvas.
[5/5] Implementing the text widget.
[4/5] Adding an object that tracks the scrolling state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line scanner identifies and counts lines in the input text and
performs wrapping if required.
Works on #4