Partial Fix for #83 (Excluding Gocyclo) #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 596
💛 - Coveralls |
mum4k
reviewed
Jan 23, 2019
Added new linestyle LineStyleDouble
mum4k
reviewed
Jan 23, 2019
draw/line_style.go
Outdated
| @@ -39,6 +39,19 @@ var lineStyleChars = map[LineStyle]map[linePart]rune{ | |||
| vAndRight: '├', | |||
| vAndH: '┼', | |||
| }, | |||
| LineStyleDouble: { | |||
There was a problem hiding this comment.
This looks great, thanks a lot!
Would you mind sending this in a separate pull request? A couple of reasons really:
- this being a new feature - I would prefer to merge it into the devel branch instead of the master and follow a release cycle.
- for the posterity - the pull request history or rollbacks become much cleaner when each pull request is focused on only one bug / feature / etc.
- we could iterate on this change a bit more without blocking your original PR regarding the lint issues. This new feature (new line style) could benefit from some test coverage. An advice I got a long time ago was to accompany each code change with at least minimal corresponding change in tests to "capture" the new feature in a working state.
I have no more comments on this PR without the new line style, so once we remove the line style from this scope - this is ready to go.
For (3) we could expand the test cases inside the border_test:
https://github.com/mum4k/termdash/blob/master/draw/border_test.go
There was a problem hiding this comment.
I've reverted the merge with the line-style.
I'll check out that test file 👍
mum4k
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the errors except for gocyclo. Its an A+ grade now