-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add openbc #195
add openbc #195
Conversation
@JeroenMulkers Travis fails, could you please rebase against master and double check it compiles? |
39a2b77
to
4ec11d4
Compare
Rebuild the kernels. Should be OK now. |
Travis succeeds |
@JeroenMulkers Are there any tests of openbc in particular? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Are there any tests of openbc in particular?
- Can we make OpenBC optional down to the axis, instead of forcing it everywhere?
Because the difference between the BC is so small, I don't really know how
to create a non-trivial test for the open BC.
It is certainly possible to make the choice of the BC dependent on the
axis. However, I do not see the point. If users are convinced that open BC
should be used, then they should use them at every boundary.
…On Fri, Sep 28, 2018 at 11:57 AM Mykola Dvornik ***@***.***> wrote:
***@***.**** commented on this pull request.
- Are there any tests of openbc in particular?
- Can we make OpenBC optional down to the axis, instead of forcing it
everywhere?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#195 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADa6qU3_vWZbKTyRS4v9b6H-yvHshiP2ks5uffKOgaJpZM4W8zPX>
.
|
@JeroenMulkers can we benefit from these tests https://github.com/fangohr/paper-supplement-standard-problem-dmi/tree/master/sims ? |
I added a test for the open BC based on the '1D' standard problem proposed by Cortés-Ortuño et al. See test/openbc.mx3 for more details. |
@JeroenMulkers I am more comfortable with 1e-5 tolerance. Can you achieve it with smaller cells? Then, would you be so kind to make three identical tests, but aligned along x, y and z? |
I could bring the tolerance down to 1e-3. The analytical result gives the canting at the edge of an infinitely long wire, whereas we of course simulate a finite wire. Therefore, it is hard to let the simulated canting converge to the analytical one. It is easy to shown that a 1D model can be simulated by using one row of cells (let's say in the x direction) and periodic boundary conditions in the y direction. Hence, we can also compare the case with open and periodic boundary conditions. In this case, a tolerance of 1e-5 can be achieved. I have added the case where the nano wire is aligned along the y direction. There is no canting at the edges of a nano wire along the z direction, so this case is not tested. |
A few notes about the implementation of open boundary conditions:
Conclusion: so far it seems to me that the difference between open and Neumann BC is rather small and, for relaxed magnetizations, becomes even smaller when one decreases the cell size.
(kernels are not yet recompiled)