Feature/shift : copy the border cells when shifting M #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating this branch to latest mumax/3
update my fork to match the mumax git
changing stopping criterion
Changed to keep previous relax() behaviour by default. When RelaxTorqueThreshold < 0, relax() will stop when the average torque rises (previous behaviour). The default value for RelaxTorqueThreshold is now -1.
default behaviour is now exactly the previous one.
adding ext_centerWallInRegion(R,c). Works like ext_centerWall but for one region alone (useful for SAFs, eg)
resetting my fork to mumax's
synchronising my fork
server page: added collapsible job lists
updating my fork
updating fork
mumax-server preserves last opened job list opened
updating my fork to match mumax3
add loupe to see details in the image on mumax result page
bug in the update image
reset my fork to mumax/3
Adds a new shift mode, that copies the values at the border cells when shifting the magnetisation instead of using the values stored in ShiftMagL/R. Modified functions: engine.Shift new functions: cuda.ShiftFudgeX, cuda.ShiftFudgeY (and related .cu, .ptx files).
Adds a new shift mode, that copies the values at the border cells when shifting the magnetisation instead of using the values stored in ShiftMagL/R. Modified functions: engine.Shift new functions: cuda.ShiftFudgeX, cuda.ShiftFudgeY (and related .cu, .ptx files).
Adds a new shift mode, that copies the values at the border cells when shifting the magnetisation instead of using the values stored in ShiftMagL/R. Modified functions: engine.Shift new functions: cuda.ShiftFudgeX, cuda.ShiftFudgeY (and related .cu, .ptx files).
|
@jsampaio Could you please clean-up this pull request to only contain |
|
@godsic : it's been a while since I proposed a change to the code, so I have to see how that is done... A unit test is a script that tests if the function is still working, like e.g. "test/centerwall.mx3" ? To propose a cleaned-up version, should I make a branch of the current mumax base on the mumax git? Every time I did a new feature on a branch of my own fork, it gets mixed up with all the other changes (like now...) |
|
Yes, you can mimic that test. Yes, please make a fork of master, then apply only |
Merged
|
This pull request is replaced by #316 (the same code, but in a clean branch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change introduces a new option for the shift. Instead of filling the new cells introduced by shift with the values of ShiftMagL and ShiftMagR, it is now possible to use the current values at the border by setting
FudgeShift = true.It is still needed to set
ShiftMagL/Rbecause they're used to determine the shift direction (as is the previous behaviour).