Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use github import paths as they always work and mumble.info does not #7

Closed
wants to merge 1 commit into from

Conversation

HorayNarea
Copy link

No description provided.

@ghost
Copy link

ghost commented Mar 28, 2016

This could just be fixed by updating mumble.info's HTTPS certificate. In the mean time, you could pass -insecure to go get:

go get -insecure -u mumble.info/grumble/cmd/grumble

@HorayNarea
Copy link
Author

I know but why not just use the github paths?
The source is hosted here and mumble.info has no informations about grumble other than "it exists"

also: i personally find it more logical that import-paths point directly to where the source "lives" but thats just my opinion :)

@HorayNarea
Copy link
Author

another argument to merge this PR: #4 (comment)

@mkrautz
Copy link
Contributor

mkrautz commented May 1, 2016

Fixed SSL for the apex mumble.info. This should work w/o any changes now.

@mkrautz mkrautz closed this May 1, 2016
@HorayNarea
Copy link
Author

No it doesn't:

go get -v -u mumble.info/grumble/cmd/grumble       
Fetching https://mumble.info/grumble/cmd/grumble?go-get=1
Parsing meta tags from https://mumble.info/grumble/cmd/grumble?go-get=1 (status code 404)
package mumble.info/grumble/cmd/grumble: unrecognized import path "mumble.info/grumble/cmd/grumble" (parse https://mumble.info/grumble/cmd/grumble?go-get=1: no go-import meta tags)

@mkrautz mkrautz reopened this May 1, 2016
@mkrautz
Copy link
Contributor

mkrautz commented May 1, 2016

Sorry. When I tested it, I "accidently" did go get mumble.info/grumble first ... which, of course, fetches the repo and makes everything work.

I'll fix it.

@mkrautz
Copy link
Contributor

mkrautz commented May 1, 2016

Should be fixed now, can you confirm?

Also, thank you for taking the time to author the patch! But I'd like to keep the current mumble.info URLs.

@HorayNarea
Copy link
Author

Yes it's working, thank you!

@HorayNarea HorayNarea closed this May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants