First version of the interpreter of Mulang #202

ludat · 2018-11-16T18:08:28Z

No description provided.

flbulgarelli · 2018-12-06T14:41:58Z

spec/InterpreterSpec.hs

+
+    it "condition is false then evals second branch" $ do
+      lastRef (run' [text|
+        if(false){


This is Nice, but it is not how JS behaves

Here I'm not testing against the value returned by the expression, but rather against the last reference created by the interpreter. So if the value is true, it will create a reference for the value in the first branch, and if false for the one in the second. That does not mean that that is the result of an expression.

luchotc · 2018-12-06T14:46:55Z

spec/InterpreterSpec.hs

+        lastRef (run "'123' == '123'") `shouldReturn` MuBool True
+
+      it "is false when values are of different types" $ do
+        lastRef (run "'123' == 123") `shouldReturn` MuBool False


This one also returns True in JS

True. I actually already commented this to @flbulgarelli and we decided that's not really important, since it's more of a quirk of JS rather than standard procedural / object-oriented behavior, which is what we actually aim to teach.

…iscard TypeFamilies and ConstraintKinds extensions

flbulgarelli · 2018-12-14T18:25:56Z

That is awesome.

Now this interpreter has also a very basic support for python, and potentially other imperative languages.

There are some things still missing, that we should address in the future:

short-circuit and and or behaviour
Introduce the idea of a primitive library, binding or SDK - or Mulang Runtime Environment, as suggested by @nscarcella in Jscompilation #145 (comment) - , specific for each language. That way, the executable data may carry that information in the monadic-transformation-pipeline, with evalPrimitive operation for the unhandled cases.
reify boolean operators instead of handling as plain references, and introduce expectations for them.

That said, I think this PR is ready to be merged.

flbulgarelli · 2018-12-14T18:27:00Z

README.md

+```
+
+```haskell
+TestGroup (MuString "succ") (Lambda [] (


We should remove those lambdas. Also we should document python test syntax

flbulgarelli · 2018-12-14T18:31:22Z

Also, we should add a contributors section and add a special notice abut this great work, crediting @ludat and @10Pines.

flbulgarelli · 2018-12-14T18:39:46Z

src/Interpreter/Runner.hs

+                | Failure String
+                deriving (Show, Eq)
+
+runTestsForDir :: String -> IO ()


We should remove this function, or parameterize it, so that is not .js-files-specific.

flbulgarelli · 2018-12-14T18:40:14Z

src/Language/Mulang/Parsers/Java.hs

@@ -91,7 +91,7 @@ muStmt (Do body cond)                  = M.While (muStmt body) (muExp cond)
 muStmt (Return exp)                    = M.Return $ fmapOrNone muExp exp
 muStmt (ExpStmt exp)                   = muExp exp
 muStmt Empty                           = None
-muStmt (Assert exp _)                  = SimpleSend Self "assert" [muExp exp]
+--muStmt (Assert exp _)                  = muAssertion $ muExp exp


We should remove this line

flbulgarelli · 2018-12-14T18:41:56Z

src/Language/Mulang/Parsers/Python.hs

+normalizeTests expr               = normalizeTest expr
+
+normalizeTest func@(M.SimpleProcedure name _ body) = case isPrefixOf "test_" name of
+                                                      True  -> M.Test (M.MuString name) body


I'd prefer to use guards here or even a local function

Or an if expression

yeah, that actually makes more sense. Whoops!

flbulgarelli · 2018-12-14T18:47:16Z

src/Interpreter/Mulang.hs

+createReference :: Value -> Executable Reference
+createReference value = do
+  nextReferenceId :: Reference <- gets (fromMaybe (Reference 10) . fmap incrementRef . getMaxKey . globalObjects)
+  modify (updateGlobalObjects $ Map.insert nextReferenceId value)


Why reference 10?

oh yeah, I saw that too. I don't think it has any special meaning, I think we could just replace that with a fromJust. I think globalObjects should never be empty.

Already talked with @julian-berbel and that 10 is useless, I think I replaced it with an exception but I never pushed that code. Initially objectSpace was empty but then I added contexts as objects and there is always at least one object alive so that 10 is never used

flbulgarelli · 2018-12-14T18:56:05Z

src/Interpreter/Mulang.hs

+
+putRef :: Reference -> Value -> Executable ()
+putRef ref val = do
+  modify $ updateGlobalObjects $ Map.insert ref val


I'd prefer to avoid overuse of application operation, and favour composition operation instead. E.g.:

modify . updateGlobalObjects $ Map.insert ref val modify . updateGlobalObjects . Map.insert ref $ val

My rule of thumb is one $ per line. Mulang code follows it quite strictly

Also, Mulang code tends to favor point-free style and avoid unnecessary do-blocks:

putRef ref = modify . updateGlobalObjects . Map.insert ref

flbulgarelli · 2018-12-14T19:00:21Z

src/Interpreter/Mulang.hs

+updateGlobalObjects f context =
+  context { globalObjects = f $ globalObjects context
+          }
+


I'd recommend one-lining simple expressions that don't require multiple span - do-expressions or really long applications.

I particularly enforce this with solo-chars:

updateGlobalObjects f context = context { globalObjects = f $ globalObjects context } updateGlobalObjects f context = context { globalObjects = f $ globalObjects context }

ludat added 3 commits November 16, 2018 14:58

Implementer working object pool to support mutation

47614e5

Added return, exception handling and test runners

54eef3e

Replaced all error calls with internal exceptions

80e43ca

ghost assigned ludat Nov 16, 2018

ghost added the pending-review label Nov 16, 2018

flbulgarelli requested review from flbulgarelli and julian-berbel November 16, 2018 21:20

julian-berbel added 11 commits November 29, 2018 15:55

add interpreter tests

9f7642d

favor not adding syntax extensions

7d1d48e

remove unused RankNTypes extension

20d5796

remove unused ExistentialQuantification extension

4031eec

remove unused FlexibleContexts extension

b38b9d4

favor implicit forall

8837314

minor syntax changes

be06282

fix mod error message

1c2e060

use Mu.Print instead of Mu.Application "print"

7082561

extract repeated logic to function

796f39f

some more style changes

3af6ea6

ghost assigned julian-berbel Nov 29, 2018

julian-berbel added 4 commits December 5, 2018 16:42

use js parser instead of plain ast expressions

4ebb7bc

add if, functions and scopes tests

1fcc713

add test runner tests

3ada237

remove LambdaCase from runner too

a799d5b

flbulgarelli reviewed Dec 6, 2018

View reviewed changes

luchotc reviewed Dec 6, 2018

View reviewed changes

julian-berbel added 5 commits December 6, 2018 16:33

add runner assert.equals test that's failing

8038d70

fix assert equals

6f01599

add while and for tests

ee91691

remove repeated test

97911d5

remove unneeded extra function from spec

a5734f8

use parameterized type instead of type equality for Executable, and d…

82ea466

…iscard TypeFamilies and ConstraintKinds extensions

flbulgarelli changed the title ~~First version of the interpreter of Mulang (specifically js)~~ First version of the interpreter of Mulang Dec 14, 2018

remove unneeded lambda element from tests and test groups

26088a0

flbulgarelli reviewed Dec 14, 2018

View reviewed changes

add test group python example to readme

7f1ce74

flbulgarelli reviewed Dec 14, 2018

View reviewed changes

update toc

fe69da3

flbulgarelli reviewed Dec 14, 2018

View reviewed changes

julian-berbel added 2 commits December 14, 2018 15:50

use if instead of case

826321b

remove java comment

d913030

flbulgarelli reviewed Dec 14, 2018

View reviewed changes

parameterize solution and test file paths

f77ccce

julian-berbel approved these changes Dec 14, 2018

View reviewed changes

flbulgarelli added 6 commits December 16, 2018 16:59

Removing hardcoded reference

87e7902

Removing unused imports

0e5581f

Parameterizing Parser in runTestsForDir

42f7237

Favoring composition operator

d39cc83

Removing some duplications

04ae0ee

Moving Interpreter to Mulang core

2a4e4ea

ghost assigned flbulgarelli Dec 16, 2018

Generalizing evalCondition

0a43e63

flbulgarelli merged commit dd055b8 into master Dec 16, 2018

ghost removed the pending-review label Dec 16, 2018

flbulgarelli deleted the interpreter branch December 16, 2018 22:08

flbulgarelli mentioned this pull request Jan 4, 2019

Allow mulang to be used as a simple REPL interpreter #213

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First version of the interpreter of Mulang #202

First version of the interpreter of Mulang #202

ludat commented Nov 16, 2018

flbulgarelli Dec 6, 2018

julian-berbel Dec 6, 2018

luchotc Dec 6, 2018

julian-berbel Dec 6, 2018

flbulgarelli commented Dec 14, 2018 •

edited

Loading

flbulgarelli Dec 14, 2018

flbulgarelli commented Dec 14, 2018

flbulgarelli Dec 14, 2018

flbulgarelli Dec 14, 2018

flbulgarelli Dec 14, 2018

flbulgarelli Dec 14, 2018

julian-berbel Dec 14, 2018

flbulgarelli Dec 14, 2018

julian-berbel Dec 14, 2018

flbulgarelli Dec 14, 2018

ludat Dec 15, 2018

flbulgarelli Dec 14, 2018 •

edited

Loading

flbulgarelli Dec 14, 2018 •

edited

Loading

flbulgarelli Dec 14, 2018

First version of the interpreter of Mulang #202

First version of the interpreter of Mulang #202

Conversation

ludat commented Nov 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flbulgarelli commented Dec 14, 2018 • edited Loading

Choose a reason for hiding this comment

flbulgarelli commented Dec 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flbulgarelli Dec 14, 2018 • edited Loading

Choose a reason for hiding this comment

flbulgarelli Dec 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flbulgarelli commented Dec 14, 2018 •

edited

Loading

flbulgarelli Dec 14, 2018 •

edited

Loading

flbulgarelli Dec 14, 2018 •

edited

Loading