Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snappy but keep SNAP installation #37

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Remove snappy but keep SNAP installation #37

merged 3 commits into from
Apr 2, 2024

Conversation

griembauer
Copy link
Member

In order to run i.sentinel.1pyrosargeocode as an alternative to snappy S-1 preprocessing, snappy has to be removed from the installation, but the Graph Processing Tool gpthas to be enabled.

WIP

@mmacata
Copy link
Member

mmacata commented Mar 27, 2024

Looks good and it doesn't look like we are able to use snappy anytime soon with recent python versions https://forum.step.esa.int/t/problem-installing-snappy-on-mac-m1/37032/5

Please really remove the lines of snappy installation instead of outcommenting. If they are needed in the future, they are easy to find with the fitting title of this PR.

@griembauer griembauer marked this pull request as ready for review April 2, 2024 06:41
Copy link
Member

@mmacata mmacata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the snap/about.py is also no longer needed, right? Then please also remove and merge directly.

@griembauer
Copy link
Member Author

Thanks, it is now deleted, I will merge now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants