Fixed trailing space in error message, and merge notary tool branch to main #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch notarization from altool to notarytool
Adds info on saving credentials on keychain for `notarytool`
team_id is also required Fix command error support Removed all altool references Try to update README with updated notarization support Closes munki#69
[notarytool branch] Fix notarization based on apple_id and password
|
I went ahead with the merge. We know the code that called altool is definitely broken now. If the new code that calls notary tool has issues, we'll deal with them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the trailing space @YesThatAllen pointed out in #53.
Also suggesting to merge to main, as the Apple notary service now officially no longer accepts uploads from altool, https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution.