Add types to exports (fixes issue #38 for ES imports) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See TypeScript issue here: microsoft/TypeScript#52363 I don't entirely follow what TS is doing, but I've based this commit on a PR linked from that discussion: gxmari007/vite-plugin-eslint#60 I don't think this will work for CJS imports as TS seems to be pedantic around file suffixes -- we may need to copy or wrap the .d.ts file somehow. I'll investigate that separately.
|
hi @iainmerrick im well aware of this situations with typescript and i think the types field in the package.json should be enough to not to cause any issue. im updating the package right now and will test if it raises any issues related to this. i will return to this pr later. |
|
hi again @iainmerrick there was more to do with type generation, importing and other kind of stuff, i had to handled it by myself. all should be fixed now. closing this pr but please let me know if you have any other problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See TypeScript issue here: microsoft/TypeScript#52363 I don't entirely follow what TS is doing, but I've based this commit on a PR linked from that discussion: gxmari007/vite-plugin-eslint#60
I don't think this will work for CJS imports as TS seems to be pedantic around file suffixes -- we may need to copy or wrap the .d.ts file somehow. I'll investigate that separately.