Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the buggy next_migration_number implementation with what ActiveR... #19

Merged
merged 2 commits into from
Feb 26, 2013

Conversation

thekindofme
Copy link
Contributor

...ecord::Generators::Base already have.

The current implementation of next_migration_number generates VERSION numbers that are too long. This results in these migrations been run last every time even if other migrations are created after these. Resulting in issues like : #14

So just use what ActiveRecord::Generators::Base already have implemented.

https://github.com/rails/rails/blob/master/activerecord/lib/rails/generators/active_record.rb#L19

muratguzel added a commit that referenced this pull request Feb 26, 2013
Replace the buggy next_migration_number implementation with what ActiveR...
@muratguzel muratguzel merged commit f7a0b08 into muratguzel:master Feb 26, 2013
@muratguzel
Copy link
Owner

thanks for your commit ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants