Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fireAsync does not properly handle multiple registrations #1

Closed
murrayju opened this issue Sep 30, 2015 · 0 comments
Closed

fireAsync does not properly handle multiple registrations #1

murrayju opened this issue Sep 30, 2015 · 0 comments

Comments

@murrayju
Copy link
Owner

It fires the last registration multiple times instead of firing each registration. This is due to a missing closure in the loop.
murrayju pushed a commit that referenced this issue Sep 30, 2015
Merge branch 'dev'
5ba740b 
* dev:
  Fix for proper semver prerelease naming. diff --git a/Gruntfile.js b/Gruntfile.js old mode 100644 new mode 100755 index ffbc053..d666d0e --- a/Gruntfile.js +++ b/Gruntfile.js @@ -289,7 +289,13 @@ module.exports = function (grunt) {          var version = grunt.file.readJSON('version.json');          // Allow the build to be set from the command line: grunt --buildNum=123          version.build = grunt.option('buildNum') || 0; -        version.info = '<%= version.major %>.<%= version.minor %>.<%= version.patch %>+<%= version.build %>.<%= gitInfo.branch %>.<%= gitInfo.revId %>'; + +        var gitInfo = grunt.config.get('gitInfo'); +        if (gitInfo.branch === 'master') { +            version.info = '<%= version.major %>.<%= version.minor %>.<%= version.patch %>+master.<%= version.build %>.<%= gitInfo.revId %>'; +        } else { +            version.info = '<%= version.major %>.<%= version.minor %>.<%= version.patch %>-<%= gitInfo.branch %>+<%= version.build %>.<%= gitInfo.revId %>'; +        }          grunt.config.set('version', version);          var infoVers = grunt.template.process(version.info);          grunt.log.writeln('Current build version: ' + infoVers);
  Added closure to the async loop to capture the proper callback fn. Fixes #1 diff --git a/src/EventHandler.coffee b/src/EventHandler.coffee old mode 100644 new mode 100755 index 10185fa..5c1a5f1 --- a/src/EventHandler.coffee +++ b/src/EventHandler.coffee @@ -24,10 +24,11 @@
  Fix repo path
  npm requires lowercase names
  dev is now v0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@murrayju