Repository navigation
Feature: name the 29 unset Speakr settings in the ASR example env file #518
Closed
branch1337
started this conversation in
Ideas
Replies: 1 comment 1 reply
|
Thank you for the suggestion. The 29 settings are now listed in |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Description
An operator who copies
config/env.asr.exampleto.envcan set the settings that file names, and cannot see the others the process already reads. The file documentsSHOW_USERNAMES_IN_UI(config/env.asr.example:337) andLLM_REQUEST_TIMEOUT(config/env.asr.example:86), then describes the connect and write timeouts as a fixed 30 seconds (config/env.asr.example:85) without namingLLM_CONNECT_TIMEOUTorLLM_WRITE_TIMEOUT. The same gap repeats for ASR auth and timeout, public-share HTML, the admin-email DNS check, webhook delivery, recording-session caps, and the Inquire and audio knobs below.Those 29 names are already live. Unset, each one falls through to the default in the reader. The example never lists them, so an operator cannot discover the name, the default, or the safe value to uncomment. Admin docs name several of them (
docs/admin-guide/system-settings.md:197and:201,docs/admin-guide/webhooks.md:268,docs/admin-guide/recording-sessions.md:132,docs/user-guide/api-reference.md:1049,docs/user-guide/pwa.md:79,docs/admin-guide/model-configuration.md:455and:570). The template an ASR install copies does not.Affected Version
v0.10.16-alpha
Requested Feature
Add the 29 variables below to
config/env.asr.exampleas comments, each set to the default the code already uses when the variable is absent. Copying the file to.envmust keep today's behavior: a commented line is not exported, and the reader keeps its current default.Leave every Python reader unchanged. Leave
env.email.example,env.sso.example,env.transcription.example,env.whisper.example, andenv.whisperx.exampleunchanged. Do not add email, SSO, other transcription connectors, S3, orENABLE_CHUNKING/CHUNK_LIMIT/CHUNK_SIZE_MB/CHUNK_OVERLAP_SECONDS. The ASR template already says ASR endpoints chunk internally and thatCHUNK_LIMITis ignored (config/env.asr.example:102).Proposed Implementation
Edit only
config/env.asr.example. Insert each group under the heading that already covers that area. Do not add a second copy of a heading that is already in the file. No function changes. The readers listed in Root Cause Analysis stay as they are.tests/test_documented_defaults.pyread_example(tests/test_documented_defaults.py:93-102) andtests/e2e/smoke_env.pyread_example(tests/e2e/smoke_env.py:30-38) skip blank lines and lines that start with#. Both loadconfig/env.whisperx.example, not this file. Commented lines inenv.asr.exampledo not change those tests. No new test is required. Do not uncomment the lines: an active assignment would change a copied.envfrom "unset, code default" to "set, same value", which is a behavior change this request does not ask for.Ready to paste. Each
# --- ... ---line is the existing section to extend, not a new section to append at the end of the file.Additional Context
Commented defaults are the code defaults, so uncommenting a line is safe.
AUTO_IDENTIFY_RESPONSE_SCHEMA=falseis off, because only1,true, andyesenable the schema (src/services/speaker_identification.py:168). EmptyASR_API_KEY,TRANSCRIPTION_MODEL_LABELS,SECRET_KEY_FILE, andWEBHOOK_INTRANET_HOST_ALLOWLISTmatch the unset behavior.Do not document
asr_timeout_seconds. It is a legacy alias read in the same expression asASR_TIMEOUT(src/services/transcription/registry.py:210).This request does not fix doc names that are not environment variables.
ENABLE_FOLDERSindocs/admin-guide/system-settings.md:185is the database settingenable_folders, and no code reads that env var.DEFAULT_RETENTION_DAYSon that page isGLOBAL_RETENTION_DAYS, already in the example.TIMEZONEonly seedsdefault_timezoneonce.CHAT_MODELandLLM_MODELare usage-tracking labels, not model selectors.VAPID_PUBLIC_KEYis not read; keys are generated underCONFIG_DIR.HF_TOKENandPRELOAD_MODELbelong to the WhisperX container.SSO_DISABLE_PASSWORD_LOGINis missing fromenv.sso.exampleand is out of scope here.PRESERVE_TEMP_AUDIO,PRESERVE_CHUNK_DEBUG, andCONFIG_DIRare also absent. They are debug and path overrides, not part of these 29.The admin docs already describe the settings this file will name. They do not need a new page.
docs/admin-guide/model-configuration.mdalready tells the operator to setPREFIX_CACHE_OPTIMIZED_PROMPTSandTRANSCRIPTION_MODEL_LABELS; after this change the ASR example agrees with that page.All reactions