-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing brainmodel and accommodating non-standard cifti #3
Conversation
…nmodel info. * Original script replaces the brain model info for voxel-type structures with only voxel_ijk * Structure label of voxel_based structure is therefore not extracted by parse_brain_label() (used by get_cifti_type())
…on (e.g., MSC). * Original code would read in cifti with dense data (vertex) as rows incorrectly.
Thanks for the PR. Before accepting please formats the vignettes to Rmd files (see |
* These Rmds are mroe documentation of this specific problem than vignettes meant to accompnay CRAN distribution or How-tos.
Hi, I added the Rmd and moved them into a folder call test_Rmd instead of letting them stay in the vignette. As they are not really how-tos or vignettes meant to distribute to CRAN. It was more to document the issue for this particular update, and if it works well, we could eventually remove them. |
Issue (1). Using read_cifti() on a cifti file with both surface and volume based structures only reads in the attributes of the surface structures.
Issue (2). dtseries.nii from MSC (Midnight Scanning Club) has non-standard dimension where the dense data is on the first dimension, so when the data is assigned into an array, it is arranged incorrectly.
Given people may use these function with the MSC data, I think its worth incorporating it into the function.