Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Moving notes with CTRL+ARROW KEYS shoud audition the notes #999

Closed
StaffanMelin opened this issue May 18, 2021 · 11 comments

Comments

@StaffanMelin
Copy link
Contributor

When moving notes with the mouse/trackpad I can hear them which is great!

Is it possible to extend this to when I move notes with CTRL+ARROW KEYS?

@kybos
Copy link
Contributor

kybos commented May 18, 2021

I don't think this is logically possible, as in that case there would be no note ON/OFF trigger (like pressing/releasing the mouse).

@StaffanMelin
Copy link
Contributor Author

StaffanMelin commented May 18, 2021

Ah, that's correct. But just a short trigger (1/4 of a sec or so) would be great, so you can hear the pitch.

@kybos
Copy link
Contributor

kybos commented May 21, 2021

But then it would probably only work with some sounds (those with short attack phase).

@StaffanMelin
Copy link
Contributor Author

Maybe they could sound until you release CTRL? :)

@kybos
Copy link
Contributor

kybos commented May 21, 2021

I suppose either until you move to the next note(s), or CTRL is released.
Can't tell ATM if it will really work or how much effort it would be to implement, but yes, it's definitely a valid requirement.

@StaffanMelin
Copy link
Contributor Author

It's no rush, it would just be useful and consistent with how it now works with dragging (which is awesome and sooo useful). Thanks for considering it!

@kybos
Copy link
Contributor

kybos commented May 22, 2021

I'm afraid it can't be really consistent, especially not with multi selection. There is no "master" item (under the mouse pointer), so how do you decide which note (or chord, depending on the setting) to play? Maybe take the first one (in time) as a workaround?
Sure not play all of them? That could result in bad cacophony...

@StaffanMelin
Copy link
Contributor Author

I think it could/would work like this:

  1. One note selected: Play that one as long as CTRL is pressed, retrigger for every move (ARROW keys)
  2. Many notes selected: Follow the drag setting (one note or chord). If on all note setting, play all notes. If on single note setting, play the earliest one. If all at the same time, play the lowest as this in most cases is the base note of the chord.

@kybos kybos closed this as completed in 7cd7c6a May 25, 2021
kybos added a commit that referenced this issue May 25, 2021
@kybos
Copy link
Contributor

kybos commented May 25, 2021

Please test, it should work more or less like described above, except:
On multi-select always the earliest note is played.
If setting = single and there are other notes on the same tick, then the lowest note value is played.
If setting = chord and there are other notes on the same tick as the earliest note, then they are played as a chord.

@StaffanMelin
Copy link
Contributor Author

It works beautifully!!!

Many thanks for this, kybos, this is a huge workflow improvement (for me)!!! :D

@kybos
Copy link
Contributor

kybos commented May 26, 2021

You're welcome ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants