optimization: lazy update of main stream events

Significantly reduces CPU load during note input
musescore · May 20, 2024 · 3c5074a · 3c5074a
1 parent 262808d
commit 3c5074a
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 10 deletions.
diff --git a/src/framework/audio/internal/abstracteventsequencer.h b/src/framework/audio/internal/abstracteventsequencer.h
@@ -56,11 +56,22 @@ class AbstractEventSequencer : public async::Asyncable
 
         m_mainStreamChanges = data.mainStream;
         m_offStreamChanges = data.offStream;
+        m_playbackEventMap = data.originEvents;
+        m_dynamicLevelMap = data.dynamicLevelMap;
+        m_playbackParamMap = data.paramMap;
 
         m_mainStreamChanges.onReceive(this,
                                       [this](const mpe::PlaybackEventsMap& events, const mpe::DynamicLevelMap& dynamics,
                                              const mpe::PlaybackParamMap& params) {
-            updateMainStreamEvents(events, dynamics, params);
+            m_playbackEventMap = events;
+            m_dynamicLevelMap = dynamics;
+            m_playbackParamMap = params;
+            m_shouldUpdateMainStreamEvents = true;
+
+            if (m_isActive) {
+                updateMainStreamEvents(events, dynamics, params);
+                m_shouldUpdateMainStreamEvents = false;
+            }
         });
 
         m_offStreamChanges.onReceive(this, [this](const mpe::PlaybackEventsMap& events, const mpe::PlaybackParamMap& params) {
@@ -76,7 +87,16 @@ class AbstractEventSequencer : public async::Asyncable
 
     void setActive(const bool active)
     {
+        if (m_isActive == active) {
+            return;
+        }
+
         m_isActive = active;
+
+        if (m_isActive && m_shouldUpdateMainStreamEvents) {
+            updateMainStreamEvents(m_playbackEventMap, m_dynamicLevelMap, m_playbackParamMap);
+            m_shouldUpdateMainStreamEvents = false;
+        }
     }
 
     bool isActive() const
@@ -230,7 +250,9 @@ class AbstractEventSequencer : public async::Asyncable
     EventSequenceMap m_offStreamEvents;
     EventSequenceMap m_dynamicEvents;
 
+    mpe::PlaybackEventsMap m_playbackEventMap;
     mpe::DynamicLevelMap m_dynamicLevelMap;
+    mpe::PlaybackParamMap m_playbackParamMap;
 
     bool m_isActive = false;
 
@@ -239,6 +261,9 @@ class AbstractEventSequencer : public async::Asyncable
 
     OnFlushedCallback m_onOffStreamFlushed;
     OnFlushedCallback m_onMainStreamFlushed;
+
+private:
+    bool m_shouldUpdateMainStreamEvents = false;
 };
 }
 

diff --git a/src/framework/audio/internal/synthesizers/fluidsynth/fluidsequencer.cpp b/src/framework/audio/internal/synthesizers/fluidsynth/fluidsequencer.cpp
@@ -65,8 +65,6 @@ void FluidSequencer::updateOffStreamEvents(const mpe::PlaybackEventsMap& events,
 void FluidSequencer::updateMainStreamEvents(const mpe::PlaybackEventsMap& events, const mpe::DynamicLevelMap& dynamics,
                                             const mpe::PlaybackParamMap&)
 {
-    m_dynamicLevelMap = dynamics;
-
     m_mainStreamEvents.clear();
     m_dynamicEvents.clear();
 

diff --git a/src/framework/vst/internal/synth/vstsequencer.cpp b/src/framework/vst/internal/synth/vstsequencer.cpp
@@ -48,9 +48,7 @@ void VstSequencer::init(ParamsMapping&& mapping)
     m_mapping = std::move(mapping);
     m_inited = true;
 
-    updateMainStreamEvents(m_playbackEventsMap, m_dynamicLevelMap, {});
-
-    m_playbackEventsMap.clear();
+    updateMainStreamEvents(m_playbackEventMap, m_dynamicLevelMap, m_playbackParamMap);
 }
 
 void VstSequencer::updateOffStreamEvents(const mpe::PlaybackEventsMap& events, const mpe::PlaybackParamMap&)
@@ -68,10 +66,7 @@ void VstSequencer::updateOffStreamEvents(const mpe::PlaybackEventsMap& events, c
 void VstSequencer::updateMainStreamEvents(const mpe::PlaybackEventsMap& events, const mpe::DynamicLevelMap& dynamics,
                                           const mpe::PlaybackParamMap&)
 {
-    m_dynamicLevelMap = dynamics;
-
     if (!m_inited) {
-        m_playbackEventsMap = events;
         return;
     }
 

diff --git a/src/framework/vst/internal/synth/vstsequencer.h b/src/framework/vst/internal/synth/vstsequencer.h
@@ -85,7 +85,6 @@ class VstSequencer : public muse::audio::AbstractEventSequencer<VstEvent, Plugin
 
     bool m_inited = false;
     ParamsMapping m_mapping;
-    mpe::PlaybackEventsMap m_playbackEventsMap;
 };
 }