Skip to content

Commit 889dc16

Browse files
committed
fix #31281
1 parent 58724c0 commit 889dc16

File tree

7 files changed

+13
-518
lines changed

7 files changed

+13
-518
lines changed

libmscore/edit.cpp

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2436,17 +2436,21 @@ void Score::checkSpanner(int startTick, int endTick)
24362436
Segment* seg = tick2segmentMM(s->tick(), false, Segment::Type::ChordRest);
24372437
if (!seg || !seg->element(s->track()))
24382438
sl.append(s);
2439-
seg = tick2segmentMM(s->tick2(), false, Segment::Type::ChordRest);
2440-
if (!seg || !seg->element(s->track2()))
2441-
sl.append(s);
2439+
else {
2440+
seg = tick2segmentMM(s->tick2(), false, Segment::Type::ChordRest);
2441+
if (!seg || !seg->element(s->track2()))
2442+
sl.append(s);
2443+
}
24422444
}
24432445
else {
24442446
// remove spanner if there is no start element
24452447
s->computeStartElement();
24462448
if (!s->startElement())
24472449
sl.append(s);
2448-
if (s->tick2() > lastTick)
2449-
s->undoChangeProperty(P_ID::SPANNER_TICKS, lastTick - s->tick());
2450+
else {
2451+
if (s->tick2() > lastTick)
2452+
s->undoChangeProperty(P_ID::SPANNER_TICKS, lastTick - s->tick());
2453+
}
24502454
}
24512455
}
24522456
for (auto s : sl) // actually remove scheduled spanners

libmscore/spannermap.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ void SpannerMap::addSpanner(Spanner* s)
7474
// check if spanner already in list
7575
for (auto i = begin(); i != end(); ++i) {
7676
if (i->second == s) {
77-
qFatal("SpannerMap::addSpanner: already in list %p", s);
77+
qFatal("SpannerMap::addSpanner: %s already in list %p", s->name(), s);
7878
}
7979
}
8080
#endif

mscore/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ QT4_WRAP_UI (ui_headers
3838
insertmeasuresdialog.ui editinstrument.ui editstyle.ui instrdialog.ui instrwidget.ui
3939
measuresdialog.ui pagesettings.ui mixer.ui playpanel.ui prefsdialog.ui measureproperties.ui
4040
textpalette.ui timedialog.ui symboldialog.ui shortcutcapturedialog.ui editdrumset.ui
41-
editstaff.ui voltaproperties.ui timesigproperties.ui boxproperties.ui
41+
editstaff.ui voltaproperties.ui timesigproperties.ui
4242
instrwizard.ui timesigwizard.ui newwizard.ui aboutbox.ui aboutmusicxmlbox.ui
4343
transposedialog.ui lineproperties.ui excerptsdialog.ui stafftext.ui tupletdialog.ui
4444
glissandoprop.ui articulation.ui metaedit.ui palette.ui select.ui
@@ -128,7 +128,7 @@ QT4_WRAP_CPP (mocs
128128
measureproperties.h seq.h textpalette.h textstyle.h selectionwindow.h
129129
timedialog.h symboldialog.h shortcutcapturedialog.h simplebutton.h
130130
greendotbutton.h recordbutton.h editdrumset.h editstaff.h selinstrument.h
131-
voltaproperties.h timesigproperties.h boxproperties.h newwizard.h
131+
voltaproperties.h timesigproperties.h newwizard.h
132132
transposedialog.h lineproperties.h
133133
excerptsdialog.h stafftextproperties.h glissandoproperties.h
134134
articulationprop.h metaedit.h magbox.h
@@ -233,7 +233,7 @@ add_executable ( ${ExecutableName}
233233
debugger/debugger.cpp menus.cpp importmidi.cpp
234234
musescore.cpp navigator.cpp pagesettings.cpp palette.cpp
235235
mixer.cpp playpanel.cpp selectionwindow.cpp preferences.cpp measureproperties.cpp
236-
seq.cpp boxproperties.cpp textpalette.cpp
236+
seq.cpp textpalette.cpp
237237
timedialog.cpp symboldialog.cpp shortcutcapturedialog.cpp
238238
simplebutton.cpp musedata.cpp
239239
# exportly.cpp

mscore/boxproperties.cpp

Lines changed: 0 additions & 81 deletions
This file was deleted.

mscore/boxproperties.h

Lines changed: 0 additions & 48 deletions
This file was deleted.

0 commit comments

Comments
 (0)