fix #40781: Visibility status of toolbar items not reflected in menu

Author: wschweer

mscore/musescore.cpp

@@ -741,15 +741,16 @@ MuseScore::MuseScore()
       menuView->addAction(getAction("zoomout"));
       menuView->addSeparator();
 
-      a = getAction("toggle-transport");
-      a->setCheckable(true);
-      a->setChecked(transportTools->isVisible());
-      menuView->addAction(a);
+//      a = getAction("toggle-transport");
+//      a->setCheckable(true);
+//      a->setChecked(transportTools->isVisible());
+//      connect(transportTools, SIGNAL(visibilityChanged(bool)), a, SLOT(setChecked(bool)));
+//      menuView->addAction(a);
 
-      a = getAction("toggle-noteinput");
-      a->setCheckable(true);
-      a->setChecked(true);
-      menuView->addAction(a);
+//      a = getAction("toggle-noteinput");
+//      a->setCheckable(true);
+//      a->setChecked(true);
+//      menuView->addAction(a);
 
       a = getAction("toggle-statusbar");
       a->setCheckable(true);
@@ -2680,10 +2681,10 @@ void MuseScore::readSettings()
       splitter->restoreState(settings.value("splitter").toByteArray());
       settings.endGroup();
 
-      QAction* a = getAction("toggle-transport");
-      a->setChecked(!transportTools->isHidden());
-      a = getAction("toggle-noteinput");
-      a->setChecked(!entryTools->isHidden());
+//      QAction* a = getAction("toggle-transport");
+//      a->setChecked(!transportTools->isHidden());
+//      a = getAction("toggle-noteinput");
+//      a->setChecked(!entryTools->isHidden());
       }
 
 //---------------------------------------------------------
@@ -4015,10 +4016,10 @@ void MuseScore::cmd(QAction* a, const QString& cmd)
             showSelectionWindow(a->isChecked());
       else if (cmd == "show-keys")
             ;
-      else if (cmd == "toggle-transport")
-            transportTools->setVisible(!transportTools->isVisible());
-      else if (cmd == "toggle-noteinput")
-            entryTools->setVisible(!entryTools->isVisible());
+//      else if (cmd == "toggle-transport")
+//            transportTools->setVisible(!transportTools->isVisible());
+//      else if (cmd == "toggle-noteinput")
+//            entryTools->setVisible(!entryTools->isVisible());
       else if (cmd == "local-help")
             helpBrowser();
       else if (cmd == "follow")

mscore/shortcut.cpp

@@ -1658,20 +1658,20 @@ Shortcut Shortcut::_sc[] = {
          Icons::Invalid_ICON,
          Qt::ApplicationShortcut
          },
-      {
-         MsWidget::MAIN_WINDOW,
-         STATE_NORMAL | STATE_NOTE_ENTRY | STATE_EDIT | STATE_LYRICS_EDIT,
-         "toggle-transport",
-         QT_TRANSLATE_NOOP("action","Transport"),
-         QT_TRANSLATE_NOOP("action","Transport toolbar")
-         },
-      {
-         MsWidget::MAIN_WINDOW,
-         STATE_NORMAL | STATE_NOTE_ENTRY | STATE_EDIT | STATE_LYRICS_EDIT,
-         "toggle-noteinput",
-         QT_TRANSLATE_NOOP("action","Note Input"),
-         QT_TRANSLATE_NOOP("action","Note input toolbar")
-         },
+//      {
+//         MsWidget::MAIN_WINDOW,
+//         STATE_NORMAL | STATE_NOTE_ENTRY | STATE_EDIT | STATE_LYRICS_EDIT,
+//         "toggle-transport",
+//         QT_TRANSLATE_NOOP("action","Transport"),
+//         QT_TRANSLATE_NOOP("action","Transport toolbar")
+//         },
+//      {
+//         MsWidget::MAIN_WINDOW,
+//         STATE_NORMAL | STATE_NOTE_ENTRY | STATE_EDIT | STATE_LYRICS_EDIT,
+//         "toggle-noteinput",
+//         QT_TRANSLATE_NOOP("action","Note Input"),
+//         QT_TRANSLATE_NOOP("action","Note input toolbar")
+//         },
       {
          MsWidget::MAIN_WINDOW,
          STATE_NORMAL | STATE_NOTE_ENTRY | STATE_EDIT | STATE_LYRICS_EDIT,