Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix #315638: wrong key signature on reset styles with concert pitch
Resolves: https://musescore.org/en/node/315638 This is not a new regression, but the reset styles command was undiscovered by most users prior to 3.6, when it was mvoed the style dialog and promoted as the way to convert old scores to the new style defaults. The original issue was that the reset of concert pitch back to the default (off) didn't update key signatures. But I suggest, people don't really think of this as a style anyhow, and we already treat it specially by giving it a toolbar button, managing it specially when generating parts, etc. And there is potentially information lost on toggling concert pitch (enharmonic spelling adjustments, etc). So this commit doesn't actually attempt to fix the key signatures. Instead, it simply adds concert pitch to the list of styles to ignore when doing the reset. This will better match user expectations and less the risk of damage. For similar reasons, I am adding multimeasure rests to the ignore list. It also is managed specially by MuseScore already, doing so again here is actually quite consistent and I think very much in line with user expectations - especially when thinking about parts where it was enabled automatically and the user might not even know how to re-enable them after reset.
- Loading branch information