-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #11362: Workspace Name Character Limit #14260
Conversation
Just added an extra condition in newworkspacemodel.cpp. Need review for the error message.
@@ -106,6 +106,11 @@ void NewWorkspaceModel::validateWorkspaceName() | |||
.arg(m_workspaceName); | |||
return; | |||
} | |||
|
|||
if (m_workspaceName.size() > 24) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @Tantacrul said #11362 (comment)
I suggest a cap of 24 characters. A user should not be able to enter more than that in the text field.
We should just ignore character input without showing an error message.
Thanks @poypoyan for working on this! My comments on this are:
This demo video is rather long (about 4:00), but you can see how confused I got 😅 Thank you so much again! |
One comment @bkunda - I was suggesting a lower character limit so that the UI doesn't end up really wide: |
I don't disagree, but I think that 24 characters is a little too constrictive. Even 40 characters feels a little more relaxed: |
We haven't met in the middle here so I'll look weak in the eyes of the community if I give way to you. The only way forward is to double down, so I'm insisting on a character limit of 10. (OK, 40's fine) |
fixed in #14288 |
Resolves: #11362
Just added an extra condition in newworkspacemodel.cpp. Need review for the error message.