Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.1] Toggle buttons are wrong colour #18274

Closed
jessjwilliamson opened this issue Jun 29, 2023 · 2 comments · Fixed by #18275
Closed

[4.1] Toggle buttons are wrong colour #18274

jessjwilliamson opened this issue Jun 29, 2023 · 2 comments · Fixed by #18275
Labels
P3 Priority: Low UI Visual issues affecting the UI (not notation)

Comments

@jessjwilliamson
Copy link
Contributor

Issue type

UI bug

Bug description

A tiny issue that the toggle button - particularly in dark mode do not match the design requirements. The white colour should be WHITE_COLOUR on both themes:
image
image

Steps to reproduce

  1. Turn app into dark mode.
  2. Go to Dev Tools
  3. Go to UI Gallery
  4. Scroll down to Toggle Button. see colour error

Screenshots/Screen recordings

In latest master the toggle button currently looks like this - which appears okay in light mode but it's wrong in dark mode:
image
image

All the circle shapes should be white_colour.

MuseScore Version

Latest master

Regression

No.

Operating system

macOS 13

Additional context

No response
@jessjwilliamson jessjwilliamson added P3 Priority: Low UI Visual issues affecting the UI (not notation) labels Jun 29, 2023
@jessjwilliamson
Copy link
Contributor Author

@HemantAntony Would be great to look at this please!

HemantAntony added a commit to HemantAntony/MuseScore that referenced this issue Jun 29, 2023
@HemantAntony
Fix musescore#18274: Toggle buttons are wrong colour
793a882
@HemantAntony HemantAntony mentioned this issue Jun 29, 2023
Merged
8 tasks
@HemantAntony
Copy link
Contributor

@jessjwilliamson check #18275 :)

@jessjwilliamson jessjwilliamson moved this from To do to Done in MuseScore 4.1 Jun 29, 2023
@jessjwilliamson jessjwilliamson moved this from Done to Needs porting in MuseScore 4.1 Jun 29, 2023
@RomanPudashkin RomanPudashkin moved this from Needs porting to In Progress in MuseScore 4.1 Jun 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in MuseScore 4.1 Jun 29, 2023
@cbjeukendrup cbjeukendrup moved this from Done to Needs porting in MuseScore 4.1 Jun 29, 2023
HemantAntony added a commit to HemantAntony/MuseScore that referenced this issue Jun 29, 2023
@HemantAntony
Fix musescore#18274: Toggle buttons are wrong colour
8294b3b
@HemantAntony HemantAntony mentioned this issue Jun 29, 2023
Merged
8 tasks
@RomanPudashkin RomanPudashkin moved this from Needs porting to Done in MuseScore 4.1 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 Priority: Low UI Visual issues affecting the UI (not notation)
Projects
No open projects
MuseScore 4.1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #18274: Toggle buttons are wrong colour HemantAntony/MuseScore
3 participants
@Eism @jessjwilliamson @HemantAntony