Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share to audio.com shouldn't show when saving a score to the cloud #20024

Closed
jessjwilliamson opened this issue Nov 14, 2023 · 0 comments · Fixed by #20025
Closed

Share to audio.com shouldn't show when saving a score to the cloud #20024

jessjwilliamson opened this issue Nov 14, 2023 · 0 comments · Fixed by #20025
Assignees
@mathesoncalum @bkunda @DmitryArefiev
Labels
needs review The issue needs review to set priority, fix version or change status etc. P1 Priority: High

Comments

@jessjwilliamson
Copy link
Contributor

Issue type

Other type of issue

Bug description

The new recently-implemented dialog on sharing score audio to audio.com is showing up when saving to cloud, when it should only happen when publishing a score.

Steps to reproduce

  1. Save a score to cloud
  2. Go through saving process
  3. See audio.com dialog at the end

Screenshots/Screen recordings

https://www.dropbox.com/scl/fi/zjpw6d4dvfx1dsjxrn2u1/Screen-Recording-2023-11-14-at-14.50.06.mov?rlkey=ee6n3s08l4wa5vjbb33d0d23h&dl=0

MuseScore Version

Latest nightly (14th November 2023)

Regression

I don't know

Operating system

MacOS 13

Additional context

No response
@jessjwilliamson jessjwilliamson added the P1 Priority: High label Nov 14, 2023
@github-project-automation github-project-automation bot moved this to To triage in MuseScore 4.2 Nov 14, 2023
@muse-bot muse-bot added the needs review The issue needs review to set priority, fix version or change status etc. label Nov 14, 2023
mathesoncalum added a commit to mathesoncalum/MuseScore that referenced this issue Nov 14, 2023
@mathesoncalum
Fix musescore#20024: Also share to audiocom flow only on publish
01708cf
@mathesoncalum mathesoncalum mentioned this issue Nov 14, 2023
Merged
@bkunda bkunda moved this from To triage to In Progress in MuseScore 4.2 Nov 14, 2023
mathesoncalum added a commit to mathesoncalum/MuseScore that referenced this issue Nov 15, 2023
@mathesoncalum
Fix x musescore#20024: Also share to audiocom flow only on publish
5367695
RomanPudashkin added a commit that referenced this issue Nov 15, 2023
@RomanPudashkin
Merge pull request #20025 from mathesoncalum/20024-audiocom_only_publish
16fc08d 
Fix #20024: Only start the "also share on Audio.com" flow after publishing (not save to cloud).
@github-project-automation github-project-automation bot moved this from In Progress to Done in MuseScore 4.2 Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathesoncalum mathesoncalum

@bkunda bkunda

@DmitryArefiev DmitryArefiev

Labels
needs review The issue needs review to set priority, fix version or change status etc. P1 Priority: High
Projects
MuseScore 4.2
Status: Done
Milestone
No milestone
5 participants
@muse-bot @mathesoncalum @jessjwilliamson @bkunda @DmitryArefiev