Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo fails to reset tablature staff's custom string assignments #21486

Open
scorster opened this issue Feb 13, 2024 · 6 comments
Open

Undo fails to reset tablature staff's custom string assignments #21486

scorster opened this issue Feb 13, 2024 · 6 comments
Assignees
Labels
needs info More information is required before action can be taken P2 Priority: Medium UX/interaction

Comments

@scorster
Copy link

scorster commented Feb 13, 2024

Issue type

UX/Interaction bug (incorrect behaviour)

Bug description

In a score with a linked Guitar + Tablature system, after a pitch change in the treble clef, and then after Undo, the treble clef correctly returns to its original pitch but MuseScore fails to restore the tablature custom string assignments.

This incomplete Undo is a real problem when the following sequence of events occurs:

    • multiple string assignments exist
    • I have a group of notes selected (for instance, an entire measure or more)
    • I accidentally drag pitch-drag the selection. The is particularly problematic as I find that MuseScore frequently scrolls the screen when I click a note, resulting in a pitch drag. (Maybe I need to turn off MagicMouse scrolling?)

After this kind of incomplete Undo the only resort is to manually reset all the non-default string assignments ... or to open a Save/Backup to see if the measure is extant therein.

Steps to reproduce

  1. New>Template>Guitar + Tablature (This creates a linked staff system)
  2. Add a note G note (the open G string, the 3rd string)
  3. In the tab staff drag the note to the D string, the 4th string (result is the fret number 5)
  4. Press Undo

see comment

Result:

  1. The treble clef reverts correctly
  2. The tablature fails to revert to its custom D string assignment. Instead it displays the default open G string.

MuseScore Version

4.2.1

Regression

Yes, this is a regression. Tablature string assignments are properly reset in MuseScore 3.6.2 after Undoing a treble staff pitch change.

Operating system

MacOS 13.5.2

@scorster
Copy link
Author

scorster commented Feb 14, 2024

Worth noting:

In the scenario outlined above: If I delete the note in the treble staff and then Undo, both the treble and tablature are fully restored ... including the tablature string assignment.

In contrast, as stated in the opening post, after changing pitch in the treble staff (in a manner that differs from the default tablature string assignments) Undo does not fully restore the tablature string assignments.

@bkunda bkunda added the needs info More information is required before action can be taken label Feb 20, 2024
@bkunda
Copy link

bkunda commented Feb 20, 2024

@DmitryArefiev I'm unable to reproduce this. Can you pls take a look?

@scorster
Copy link
Author

scorster commented Feb 20, 2024

This issue is 100% persistent here on MacOS 13.5.2 MuseScore 4.2.1.

Please see the attached example score with steps to replicate.

Undo and Tablature string assignments 02.mscz.zip

@MarcSabatella
Copy link
Contributor

Confirmed here as well. If a transposition using Tools / Transpose results in string assignments changing, undo does not restore the originals.

@DmitryArefiev
Copy link
Contributor

This issue is 100% persistent here on MacOS 13.5.2 MuseScore 4.2.1.

Please see the attached example score with steps to replicate.

Undo and Tablature string assignments 02.mscz.zip

Yes, I can reproduce in 4.3

bandicam.2024-05-08.14-20-45-531.mp4

@DmitryArefiev
Copy link
Contributor

@scorster Are you sure it's a regression? I can reproduce it in 3.6.2 as well:

bandicam.2024-05-08.14-22-42-628.mp4

@DmitryArefiev DmitryArefiev added this to To do in 4.x SHORTLIST via automation May 8, 2024
@DmitryArefiev DmitryArefiev added the P2 Priority: Medium label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs info More information is required before action can be taken P2 Priority: Medium UX/interaction
Projects
Status: One of the next releases
4.x SHORTLIST
  
To do
Development

No branches or pull requests

5 participants