fix #36366: parse verse number, left align to syllable #1391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue and in #1322, it is desirable to move away from separate Verse Number elements and toward a scheme where we automatically process leading verse numbers in lyric syllables. This PR implements such a scheme. If a lyric of the form
digits (optional separators) word
then the digits are taken to be a verse number, and the lyric is left aligned at the start of the word. A lyric consisting of digits only is not affected, so you can use numbers as lyrics with no problems.
I also elected to address http://musescore.org/en/node/24856 - ignoring leading punctuation - since it was easy to deal with both leading digitas and leading punctuation at the same time. Leading punctuation is ignored when positioning lyrics just as leading digits are, but the syllable is still centered.
I also fixed an issue where if you explicitly set the lyric style to left aligned, bad things happened with melisma. Again, I was modifying this code anyhow, this fix came for free.