Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector offset property: fix editing x and y value individually when multiple elements are selected with potentially different values for x and/or y #15772

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Nov 4, 2023

  1. Configuration menu
    Copy the full SHA
    0f0d78e View commit details
    Browse the repository at this point in the history
  2. Inspector: introduce more flexibility for setting properties

    Necessary for "compound" properties, where we use multiple PropertyItems for what's under the hood a single property. In this situation, when setting the value for one part of the property, the other parts of the property need to be preserved _for each element individually_, because the other parts might differ per element. Therefore, we introduce the possibility to inject a custom function to convert from QVariant to PropertyValue per element.
    cbjeukendrup committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    9c7e54c View commit details
    Browse the repository at this point in the history
  3. Inspector: fix offset properties

    In 6ded409, we had made offset properties a single PropertyItem to fix some problems with applying to style. This turns out to cause other problems, because we want to be able to edit x and y values separately, also when multiple items are selected, see musescore#15452.
    cbjeukendrup committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    ca6853f View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Configuration menu
    Copy the full SHA
    c04cce3 View commit details
    Browse the repository at this point in the history