Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #42936: beam distance doesn't scale with staff size #1599

Merged

Conversation

MarcSabatella
Copy link
Contributor

This re-fixes the problem without breaking grace notes. vtest added for both cases.

BTW, when I load the beams-1 vtest, I get different results from the reference, and this has been true for as long as I can remember. The beam in the master for the first note clears the top staff line by a beam-width or so, but in when I load the file, the beam overlaps the staff line. I have no idea which is intended or more correct, but I can't figure out why there is a discrepency. @wschweer?

Here is what I see, with or without my change in this PR:

beams-1-1

@wschweer
Copy link
Contributor

wschweer commented Jan 2, 2015

Some time ago i did a small change for calculating the stem length. The current version looks better so i updated the reference file.

wschweer added a commit that referenced this pull request Jan 2, 2015
fix #42936: beam distance doesn't scale with staff size
@wschweer wschweer merged commit 0e4993c into musescore:master Jan 2, 2015
@MarcSabatella
Copy link
Contributor Author

I had assumed that initially, but then I noticed that the version with longer stems is what the automated vtests on Travis have been and still are producing. See for example http://vtest.musescore.org/f471d311/vtest.html, a vtest run on Travis earlier today (after your change). So somehow, this file still produces a different result on Travis than on our systems. Maybe still some floating point comparison issues somewhere?

@lasconic
Copy link
Contributor

lasconic commented Jan 3, 2015

If it helps, travis is running Qt 5.3.1 on Ubuntu 12.04 64 bit, vtest are
rendered using xvfb-run since there is no X server running.

2015-01-02 17:28 GMT+01:00 Marc Sabatella notifications@github.com:

I had assumed that initially, but then I noticed that the version with
longer stems is what the automated vtests on Travis have been and still are
producing. See for example http://vtest.musescore.org/f471d311/vtest.html,
a vtest run on Travis earlier today (after your change). So somehow, this
file still produces a different result on Travis than on our systems. Maybe
still some floating point comparison issues somewhere?


Reply to this email directly or view it on GitHub
#1599 (comment).

@MarcSabatella
Copy link
Contributor Author

It helps me decide not to worry any more about it for now, then :-). I guess at some point travis will be updated to Qt 5.4 and we'll find out if that's the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants