Entering lyrics underscore at score end #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a lyrics underscore is entered at score end (or where there is no place for a suitable new/next lyrics to move to): - the last underscore gives no visual feedback, until the score is re-laid out - the score view is left in a vague state (lyrics edit mode with no current lyrics) Fixed by updating lyrics melisma display and leaving edit mode. The lyrics whose melisma is being edited is also selected to give the user some 'cursor'.
wschweer
added a commit
that referenced
this pull request
Jan 19, 2015
…_end Entering lyrics underscore at score end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a lyrics underscore is entered at score end (or where there is no place for a suitable new/next lyrics to move to):
Fixed by updating lyrics melisma display and leaving edit mode.
The lyrics whose melisma is being edited is also selected to give the user some 'cursor'.